Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect ignoreCase flag in CommonGramsFilterFactory #781

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

chenhh021
Copy link
Contributor

Fix #780.

@paulirwin
Copy link
Contributor

For posterity, this is a port of apache/lucene#188 although only part of that PR. I think this is a fairly reasonable change to make, as it does not change the public API surface and seems like it was clearly intended to function this way. I think we can include this in 4.8 unless @NightOwl888 disagrees. Adding to the beta 18 milestone for now.

@paulirwin paulirwin added this to the 4.8.0-beta00018 milestone Oct 24, 2024
@paulirwin paulirwin self-assigned this Oct 28, 2024
@paulirwin paulirwin requested a review from NightOwl888 October 29, 2024 17:25
Copy link
Contributor

@NightOwl888 NightOwl888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While normally I don't like to accept any future updates without getting the entire patch, there doesn't seem to be much benefit from the rest of the changes as they apply a AbstractWordsFileFilterFactory which doesn't yet exist. And since this fixes a bug, it seems appropriate.

There was one incorrectly translated line, that we should fix, though. See the inline comment.

@NightOwl888 NightOwl888 added the notes:bug-fix Contains a fix for a bug label Nov 6, 2024
@NightOwl888 NightOwl888 merged commit de280b0 into apache:master Nov 11, 2024
197 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes:bug-fix Contains a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CommonGramsFilterFactory doesn't respect ignoreCase=true when default stopwords are used
3 participants