Upgrade NUnit to 3.14 and update test adapter and VS test SDK packages #1000
Conversation
There was a problem hiding this comment.
The good news is we can upgrade to 3.14.0 because the features that NUnit added were already present in 3.13.1, which is the version we were targeting when repeatable random test support was added.
The bad news is, until we do some more work to stabilize and add tests to the test framework (which is still experimental, see #547), I don't think upgrades are a thing we can support.
We are missing the scans for the FixtureLifecycleAttribute, and I don't recall whether that was an intentional design choice or if I was porting from an older version of NUnit (this line was added in 3.13.1). But as long as we own a chunk of NUnit code, we cannot guarantee new NUnit features will work if someone upgrades the NUnit version. IIRC, we also don't support all of NUnit's features (similar to how randomized-testing doesn't support all of JUnit's features).
I think we can leave the versioning as-is for this PR, but we should probably consider whether to put a version constraint on this so upgrades to 4.x are not possible for users. At least until we can spec out some extensibility for NUnit to add so we don't have to own a chunk of their code. But before we do that, we really should finish #1017 so we can work out what other parts of NUnit will need extending to support our test framework and randomized testing (#264) going forward.
|
@NightOwl888 Thanks! Great info, as always. Also related: #1001 to upgrade to 4.x hopefully someday. |
Upgrade NUnit to 3.14.0, as well as the test adapter and VS test SDK packages.
Related #259
Description
This fixes an issue in Rider with test discovery, impacting the ability to see and individually run child tests of test classes.