Skip to content

Commit

Permalink
lucene-cli: Removed target and tests for net6.0 (fixes #979) (#981)
Browse files Browse the repository at this point in the history
  • Loading branch information
NightOwl888 authored Oct 21, 2024
1 parent 78e40ac commit e300f54
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ steps:
testResultsArtifactName: '${{ parameters.testResultsArtifactName }}'
testResultsFileName: '${{ parameters.testResultsFileName }}'

# Special case: Only supports net8.0 and net6.0
# Special case: Only supports net8.0
- template: publish-test-results.yml
parameters:
testProjectName: 'Lucene.Net.Tests.Cli'
Expand All @@ -92,16 +92,6 @@ steps:
testResultsArtifactName: '${{ parameters.testResultsArtifactName }}'
testResultsFileName: '${{ parameters.testResultsFileName }}'

- template: publish-test-results.yml
parameters:
testProjectName: 'Lucene.Net.Tests.Cli'
framework: 'net6.0' # Since condtions are not supported for templates, we check for the file existence within publish-test-results.yml
vsTestPlatform: '${{ parameters.vsTestPlatform }}'
osName: '${{ parameters.osName }}'
testResultsFormat: '${{ parameters.testResultsFormat }}'
testResultsArtifactName: '${{ parameters.testResultsArtifactName }}'
testResultsFileName: '${{ parameters.testResultsFileName }}'

# Special case: Only supports net8.0, net6.0 and net48

- template: publish-test-results.yml
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@

<PropertyGroup>
<!-- Allow specific target framework to flow in from TestTargetFrameworks.props -->
<TargetFrameworks Condition=" '$(TargetFramework)' == '' ">net8.0;net6.0</TargetFrameworks>
<TargetFrameworks Condition=" '$(TargetFramework)' == '' ">net8.0</TargetFrameworks>
<AssemblyTitle>Lucene.Net.Tests.Cli</AssemblyTitle>
</PropertyGroup>

<PropertyGroup Condition=" $(TargetFramework.StartsWith('net4')) Or $(TargetFramework.StartsWith('net5.')) ">
<PropertyGroup Condition=" $(TargetFramework.StartsWith('net4')) Or $(TargetFramework.StartsWith('net5.')) Or $(TargetFramework.StartsWith('net6.')) ">
<!-- For CI, we don't publish the projects and exclude them from the test run by setting IsPublishable=false and IsTestProject=false -->
<IsPublishable>false</IsPublishable>
<IsTestProject>false</IsTestProject>
Expand Down
4 changes: 2 additions & 2 deletions src/dotnet/tools/lucene-cli/lucene-cli.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@
<Import Project="$(SolutionDir).build/nuget.props" />

<PropertyGroup>
<TargetFrameworks>net8.0;net6.0</TargetFrameworks>
<TargetFrameworks>net8.0</TargetFrameworks>
<RollForward Condition=" $(TargetFramework.StartsWith('net8.')) ">Major</RollForward>

<IsPublishable>false</IsPublishable>
<IsPublishable Condition="'$(TargetFramework)' == 'net8.0' Or '$(TargetFramework)' == 'net6.0'">true</IsPublishable>
<IsPublishable Condition="'$(TargetFramework)' == 'net8.0'">true</IsPublishable>
<PackAsTool>true</PackAsTool>
<ToolCommandName>lucene</ToolCommandName>

Expand Down

0 comments on commit e300f54

Please sign in to comment.