Explicitly disable attach-scaladocs for pure Java modules #6820
+12
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
branch-1.8 Java 17 CI is broken due to this, I'd like to have it before releasing 1.8.3 |
cxzl25
approved these changes
Nov 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6820 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 687 687
Lines 42442 42442
Branches 5793 5793
======================================
Misses 42442 42442 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
pan3793
added a commit
that referenced
this pull request
Nov 22, 2024
# 🔍 Description ``` export JAVA_HOME=/path/of/openjdk-17 build/mvn clean install -DskipTests -Dmaven.scaladoc.skip=false ``` ``` [INFO] --- scala-maven-plugin:4.9.2:doc-jar (attach-scaladocs) kyuubi-server-plugin --- [INFO] compiler plugin: BasicArtifact(com.github.ghik,silencer-plugin_2.12.20,1.7.19,null) error: fatal error: object scala in compiler mirror not found. ``` ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 Successfully run the build command ``` export JAVA_HOME=/path/of/openjdk-17 build/mvn clean install -DskipTests -Dmaven.scaladoc.skip=false ``` --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6820 from pan3793/scaladoc. Closes #6820 f5cee34 [Cheng Pan] Explicitly disable attach-scaladocs for pure Java modules Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 4b506f4) Signed-off-by: Cheng Pan <[email protected]>
pan3793
added a commit
that referenced
this pull request
Nov 22, 2024
``` export JAVA_HOME=/path/of/openjdk-17 build/mvn clean install -DskipTests -Dmaven.scaladoc.skip=false ``` ``` [INFO] --- scala-maven-plugin:4.9.2:doc-jar (attach-scaladocs) kyuubi-server-plugin --- [INFO] compiler plugin: BasicArtifact(com.github.ghik,silencer-plugin_2.12.20,1.7.19,null) error: fatal error: object scala in compiler mirror not found. ``` - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) Successfully run the build command ``` export JAVA_HOME=/path/of/openjdk-17 build/mvn clean install -DskipTests -Dmaven.scaladoc.skip=false ``` --- - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6820 from pan3793/scaladoc. Closes #6820 f5cee34 [Cheng Pan] Explicitly disable attach-scaladocs for pure Java modules Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 4b506f4) Signed-off-by: Cheng Pan <[email protected]>
pan3793
added a commit
that referenced
this pull request
Nov 22, 2024
``` export JAVA_HOME=/path/of/openjdk-17 build/mvn clean install -DskipTests -Dmaven.scaladoc.skip=false ``` ``` [INFO] --- scala-maven-plugin:4.9.2:doc-jar (attach-scaladocs) kyuubi-server-plugin --- [INFO] compiler plugin: BasicArtifact(com.github.ghik,silencer-plugin_2.12.20,1.7.19,null) error: fatal error: object scala in compiler mirror not found. ``` - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) Successfully run the build command ``` export JAVA_HOME=/path/of/openjdk-17 build/mvn clean install -DskipTests -Dmaven.scaladoc.skip=false ``` --- - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6820 from pan3793/scaladoc. Closes #6820 f5cee34 [Cheng Pan] Explicitly disable attach-scaladocs for pure Java modules Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 4b506f4) Signed-off-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Types of changes 🔖
Test Plan 🧪
Successfully run the build command
Checklist 📝
Be nice. Be informative.