Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD]Replace systemProperties with systemPropertyVariables in maven-surefire-plugin #6808

Closed
wants to merge 3 commits into from

Conversation

pionCham
Copy link
Contributor

@pionCham pionCham commented Nov 13, 2024

🔍 Description

Issue References 🔗

Describe Your Solution 🔧

Fix the warning of maven-surefire-plugin that show Parameter 'systemProperties' is deprecated. Use systemPropertyVariables instead. in the build.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@pionCham pionCham changed the title [Build]Replace systemProperties with systemPropertyVariables [BUILD]Replace systemProperties with systemPropertyVariables Nov 13, 2024
@pionCham pionCham marked this pull request as draft November 13, 2024 03:13
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (dddb037) to head (668bfe2).
Report is 2 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6808   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         687     687           
  Lines       42442   42442           
  Branches     5793    5793           
======================================
  Misses      42442   42442           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pom.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@bowenliang123 bowenliang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please update the title and description to explain the reasons and changes.

@pionCham pionCham changed the title [BUILD]Replace systemProperties with systemPropertyVariables [BUILD]Replace systemProperties with systemPropertyVariables in maven-surefire-plugin Nov 13, 2024
@pionCham
Copy link
Contributor Author

pionCham commented Nov 13, 2024

LGTM. Please update the title and description to explain the reasons and changes.

I have updated the description and title.

@bowenliang123 bowenliang123 marked this pull request as ready for review November 13, 2024 14:40
@bowenliang123 bowenliang123 added this to the v1.10.1 milestone Nov 13, 2024
bowenliang123 pushed a commit that referenced this pull request Nov 13, 2024
…iables in maven-surefire-plugin

# 🔍 Description
## Issue References 🔗

## Describe Your Solution 🔧
Fix the warning of `maven-surefire-plugin` that show `Parameter 'systemProperties' is deprecated. Use systemPropertyVariables instead.` in the build.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6808 from pionCham/use-systemPropertyVariables.

Closes #6808

668bfe2 [chengpeiming] Replace  systemProperties with systemPropertyVariables in maven-surefire-plugin
0e74b47 [chengpeiming] Revert "Replace systemProperties with systemPropertyVariables"
797384a [chengpeiming] Replace systemProperties with systemPropertyVariables

Authored-by: chengpeiming <[email protected]>
Signed-off-by: Bowen Liang <[email protected]>
(cherry picked from commit ad53eef)
Signed-off-by: Bowen Liang <[email protected]>
@bowenliang123
Copy link
Contributor

Thanks, merged to master (1.11.0) and branch-1.10 (1.10.1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants