-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUILD]Replace systemProperties with systemPropertyVariables in maven-surefire-plugin #6808
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6808 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 687 687
Lines 42442 42442
Branches 5793 5793
======================================
Misses 42442 42442 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please update the title and description to explain the reasons and changes.
I have updated the description and title. |
…iables in maven-surefire-plugin # 🔍 Description ## Issue References 🔗 ## Describe Your Solution 🔧 Fix the warning of `maven-surefire-plugin` that show `Parameter 'systemProperties' is deprecated. Use systemPropertyVariables instead.` in the build. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6808 from pionCham/use-systemPropertyVariables. Closes #6808 668bfe2 [chengpeiming] Replace systemProperties with systemPropertyVariables in maven-surefire-plugin 0e74b47 [chengpeiming] Revert "Replace systemProperties with systemPropertyVariables" 797384a [chengpeiming] Replace systemProperties with systemPropertyVariables Authored-by: chengpeiming <[email protected]> Signed-off-by: Bowen Liang <[email protected]> (cherry picked from commit ad53eef) Signed-off-by: Bowen Liang <[email protected]>
Thanks, merged to master (1.11.0) and branch-1.10 (1.10.1). |
🔍 Description
Issue References 🔗
Describe Your Solution 🔧
Fix the warning of
maven-surefire-plugin
that showParameter 'systemProperties' is deprecated. Use systemPropertyVariables instead.
in the build.Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.