Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Specify JDK 11 for spark engine on kubernetes IT #6763

Closed
wants to merge 1 commit into from

Conversation

wForget
Copy link
Member

@wForget wForget commented Oct 21, 2024

🔍 Description

Issue References 🔗

Spark Engine On Kubernetes Integration Test always fails after #6739

The default java version of Ubuntu 24.04 is OpenJDK 21: https://discourse.ubuntu.com/t/ubuntu-24-04-lts-noble-numbat-release-notes/39890#openjdk , this is a version higher than that supported by spark 3.5.X.

Describe Your Solution 🔧

Specify JDK 11 for spark engine on kubernetes it.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

test ga: https://github.com/wForget/kyuubi/actions/runs/11441231714/job/31828818049


Checklist 📝

Be nice. Be informative.

@github-actions github-actions bot added the kind:infra license, community building, project builds, asf infra related, etc. label Oct 21, 2024
@wForget wForget changed the title Specify JDK 17 for spark engine on kubernetes it Specify JDK 11 for spark engine on kubernetes it Oct 21, 2024
@wForget wForget marked this pull request as draft October 21, 2024 13:29
@pan3793
Copy link
Member

pan3793 commented Oct 21, 2024

I feel like that maven.compiler.release should be set to the minimal supported JDK version, for our case, it should be 8 instead of following the compile JDK version.

@wForget
Copy link
Member Author

wForget commented Oct 21, 2024

I feel like that maven.compiler.release should be set to the minimal supported JDK version, for our case, it should be 8 instead of following the compile JDK version.

Should this version be consistent with the jdk version used to build the spark image (apache/spark:3.5.2)?

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (1e9d68b) to head (aee3933).
Report is 3 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6763   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         684     684           
  Lines       42353   42354    +1     
  Branches     5775    5776    +1     
======================================
- Misses      42353   42354    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bowenliang123
Copy link
Contributor

BTW, the default JDK on Ubuntu 24.04 is version 21. https://launchpad.net/ubuntu/noble/amd64/default-jdk

@bowenliang123
Copy link
Contributor

I feel like that maven.compiler.release should be set to the minimal supported JDK version, for our case, it should be 8 instead of following the compile JDK version.

SGTM. Testing it in #6766.

@wForget
Copy link
Member Author

wForget commented Oct 22, 2024

I feel like that maven.compiler.release should be set to the minimal supported JDK version, for our case, it should be 8 instead of following the compile JDK version.

SGTM. Testing it in #6766.

Thank you, that's a better way, I will close this

@wForget wForget closed this Oct 22, 2024
@bowenliang123 bowenliang123 reopened this Oct 22, 2024
@bowenliang123 bowenliang123 changed the title Specify JDK 11 for spark engine on kubernetes it [CI] Specify JDK 11 for spark engine on kubernetes IT Oct 22, 2024
@wForget wForget marked this pull request as ready for review October 22, 2024 03:25
@bowenliang123
Copy link
Contributor

As #6766 requires further polishment and investigation, we still need this patch as a workaround to pass the CI tests.

@bowenliang123 bowenliang123 added this to the v1.10.0 milestone Oct 22, 2024
Copy link
Contributor

@bowenliang123 bowenliang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All the tests on K8s passed.

@bowenliang123
Copy link
Contributor

Thanks, merged to master (1.10.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:infra license, community building, project builds, asf infra related, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants