-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Specify JDK 11 for spark engine on kubernetes IT #6763
Conversation
I feel like that |
Should this version be consistent with the jdk version used to build the spark image (apache/spark:3.5.2)? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6763 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 684 684
Lines 42353 42354 +1
Branches 5775 5776 +1
======================================
- Misses 42353 42354 +1 ☔ View full report in Codecov by Sentry. |
BTW, the default JDK on Ubuntu 24.04 is version 21. https://launchpad.net/ubuntu/noble/amd64/default-jdk |
SGTM. Testing it in #6766. |
Thank you, that's a better way, I will close this |
As #6766 requires further polishment and investigation, we still need this patch as a workaround to pass the CI tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. All the tests on K8s passed.
Thanks, merged to master (1.10.0) |
🔍 Description
Issue References 🔗
Spark Engine On Kubernetes Integration Test
always fails after #6739The default java version of Ubuntu 24.04 is OpenJDK 21: https://discourse.ubuntu.com/t/ubuntu-24-04-lts-noble-numbat-release-notes/39890#openjdk , this is a version higher than that supported by spark 3.5.X.
Describe Your Solution 🔧
Specify JDK 11 for spark engine on kubernetes it.
Types of changes 🔖
Test Plan 🧪
test ga: https://github.com/wForget/kyuubi/actions/runs/11441231714/job/31828818049
Checklist 📝
Be nice. Be informative.