Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #6726] Support trino stage progress #6759

Closed
wants to merge 5 commits into from

Conversation

taylor12805
Copy link

@taylor12805 taylor12805 commented Oct 18, 2024

🔍 Description

Issue References 🔗

This pull request fixes #6726

Describe Your Solution 🔧

Add trino statement progress

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@taylor12805 taylor12805 marked this pull request as draft October 18, 2024 12:10
@pan3793 pan3793 requested a review from lsm1 October 18, 2024 12:48
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (2d64255) to head (6646c95).
Report is 56 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #6759    +/-   ##
=======================================
  Coverage    0.00%   0.00%            
=======================================
  Files         684     687     +3     
  Lines       42282   42442   +160     
  Branches     5767    5793    +26     
=======================================
- Misses      42282   42442   +160     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lsm1
Copy link
Contributor

lsm1 commented Oct 21, 2024

@taylor12805 Before submitting the pull request, we can use ./dev/reformat to format the code.

@taylor12805
Copy link
Author

@taylor12805 Before submitting the pull request, we can use ./dev/reformat to format the code.

@lsm1 thanks for reminding. I added test case for trino statement progress, however since trino don't have sleep function, I can't mock multiple stages case. Do you have some ideas?

@taylor12805 taylor12805 marked this pull request as ready for review October 21, 2024 07:47
@lsm1
Copy link
Contributor

lsm1 commented Oct 22, 2024

@taylor12805* Before submitting the pull request, we can use ./dev/reformat to format the code.

@lsm1* thanks for reminding. I added test case for trino statement progress, however since trino don't have sleep function, I can't mock multiple stages case. Do you have some ideas?

Adding a sleep function in Trino is not straightforward, so simple unit tests should be sufficient for now.

@cxzl25 cxzl25 added this to the v1.11.0 milestone Nov 19, 2024
@lsm1
Copy link
Contributor

lsm1 commented Nov 19, 2024

@taylor12805 Please fix the failing test

- get operation progress *** FAILED ***
  The code passed to eventually never returned normally. Attempted 1623 times over 25.002736579 seconds. Last failure message: Expected List("Stage-0 ........", "FINISHED", "5", "5", "0", "0", "0", ""), but got Buffer("Stage-0 ........", "FINISHED", "3", "3", "0", "0", "0", ""). (TrinoOperationProgressSuite.scala:43)

@yaooqinn yaooqinn closed this in 160bf58 Nov 22, 2024
@pan3793
Copy link
Member

pan3793 commented Nov 22, 2024

unfortunately, this patch fails the scala 2.13 CI, @taylor12805 could you please fix that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] support trino stage progress
6 participants