skip repeated checking on convert function

apache · Oct 29, 2024 · 977d215 · 977d215
1 parent d3520dd
commit 977d215
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/kyuubi-common/src/main/scala/org/apache/kyuubi/engine/result/TColumnGenerator.scala b/kyuubi-common/src/main/scala/org/apache/kyuubi/engine/result/TColumnGenerator.scala
@@ -32,17 +32,19 @@ trait TColumnGenerator[RowT] extends TRowSetColumnGetter[RowT] {
       convertFunc: (RowT, Int) => T = null): (JList[T], ByteBuffer) = {
     val rowSize = rows.length
     val ret = new JArrayList[T](rowSize)
-    val nulls = new JBitSet()
+    val nulls = new JBitSet(rowSize)
+    val isConvertFuncDefined = Option(convertFunc).isDefined
     var idx = 0
     rows.foreach { row =>
       val isNull = isColumnNullAt(row, ordinal)
       if (isNull) {
         nulls.set(idx, true)
         ret.add(defaultVal)
       } else {
-        val value = Option(convertFunc) match {
-          case Some(f) => f(row, ordinal)
-          case _ => getColumnAs[T](row, ordinal)
+        val value = if (isConvertFuncDefined) {
+          convertFunc(row, ordinal)
+        } else {
+          getColumnAs[T](row, ordinal)
         }
         ret.add(value)
       }