Skip to content

Commit

Permalink
Limit visibility of test method per review
Browse files Browse the repository at this point in the history
  • Loading branch information
ashvina committed Dec 18, 2024
1 parent b574355 commit 41575fd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public class DeltaStatsExtractor {
/* this data structure collects type names of all unrecognized Delta Lake stats. For instance
data file stats in presence of delete vectors would contain 'tightBounds' stat which is
currently not handled by XTable */
private static final Set<String> unsupportedStats = new HashSet<>();
private final Set<String> unsupportedStats = new HashSet<>();

public static DeltaStatsExtractor getInstance() {
return INSTANCE;
Expand Down Expand Up @@ -272,7 +272,7 @@ private Map<String, Object> flattenStatMap(Map<String, Object> statMap) {
* @return set of unsupported stats
*/
@VisibleForTesting
public static Set<String> getUnsupportedStats() {
Set<String> getUnsupportedStats() {
return Collections.unmodifiableSet(unsupportedStats);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ void convertStatsToInternalRepresentation() throws IOException {
AddFile addFile = new AddFile("file://path/to/file", null, 0, 0, true, stats, null, null);
DeltaStatsExtractor extractor = DeltaStatsExtractor.getInstance();
List<ColumnStat> actual = extractor.getColumnStatsForFile(addFile, fields);
Set<String> unsupportedStats = DeltaStatsExtractor.getUnsupportedStats();
Set<String> unsupportedStats = extractor.getUnsupportedStats();
assertEquals(2, unsupportedStats.size());
assertTrue(unsupportedStats.contains("tightBounds"));
assertTrue(unsupportedStats.contains("nonExisting"));
Expand Down

0 comments on commit 41575fd

Please sign in to comment.