Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kie-issues#1734: KIE Tools: TypeError when invoking Java method inside BKM #2831

Merged
merged 2 commits into from
Jan 3, 2025
Merged

kie-issues#1734: KIE Tools: TypeError when invoking Java method inside BKM #2831

merged 2 commits into from
Jan 3, 2025

Conversation

Kusuma04-dev
Copy link
Contributor

closes apache/incubator-kie-issues#1734 TypeError when invoking Java method inside BKM

@danielzhe danielzhe self-requested a review December 30, 2024 20:13
@Kusuma04-dev Kusuma04-dev mentioned this pull request Jan 2, 2025
Closed
jomarko
jomarko approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm now the java function class and method signature can be edited as in BKM node so in Decision Node - Context Entry - Function

ljmotta
ljmotta requested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@ljmotta ljmotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kusuma04-dev Thanks for the PR, I've made some comments inline.

...ges/boxed-expression-component/src/expressions/FunctionExpression/JavaFunctionExpression.tsx Outdated Show resolved Hide resolved
...ges/boxed-expression-component/src/expressions/FunctionExpression/JavaFunctionExpression.tsx Outdated
clazz,
{
...method,
expression: newExpression,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

danielzhe
danielzhe approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@danielzhe danielzhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

ljmotta
ljmotta approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@ljmotta ljmotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kusuma04-dev LGTM!

@ljmotta ljmotta merged commit 88ce385 into apache:main Jan 3, 2025
15 checks passed
@yesamer yesamer changed the title kie-issues#2821: KIE Tools: TypeError when invoking Java method inside BKM kie-issues#1734: KIE Tools: TypeError when invoking Java method inside BKM Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbowers-ibm kbowers-ibm kbowers-ibm approved these changes

@ljmotta ljmotta ljmotta approved these changes

@jomarko jomarko jomarko approved these changes

@danielzhe danielzhe danielzhe approved these changes

@tiagobento tiagobento Awaiting requested review from tiagobento tiagobento is a code owner

Assignees
No one assigned
Labels
area:dmn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError when invoking Java method inside BKM
5 participants
@Kusuma04-dev @danielzhe @jomarko @ljmotta @kbowers-ibm