Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Maven plugins update #2819

Closed
wants to merge 9 commits into from
Closed

NO-ISSUE: Maven plugins update #2819

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a1422c7
pom
yesamer Dec 17, 2024
15999bd
Minor
yesamer Dec 17, 2024
47dd0a8
minor
yesamer Dec 17, 2024
3355855
revert jar version
yesamer Dec 17, 2024
f5c5e2b
removing stale profile
yesamer Dec 17, 2024
e904646
Merge remote-tracking branch 'origin/main' into updating-plugins
yesamer Dec 17, 2024
6ebc956
CR
yesamer Dec 18, 2024
8a18eaf
Dashbuilder updated
yesamer Dec 18, 2024
58020e7
dashbuilder
yesamer Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 3 additions & 19 deletions packages/dev-deployment-dmn-form-webapp/dev-webapp/quarkus-app/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
<version>32</version>
<version>33</version>
</parent>

<modelVersion>4.0.0</modelVersion>
Expand All @@ -42,18 +42,8 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>

<!-- Maven versions -->
<version.maven.artifact.plugin>3.4.1</version.maven.artifact.plugin>
<version.maven.compiler.plugin>3.13.0</version.maven.compiler.plugin>
<version.maven.resources.plugin>3.2.0</version.maven.resources.plugin>
<version.maven.failsafe.plugin>3.0.0-M7</version.maven.failsafe.plugin>
<version.maven.surefire.plugin>3.5.0</version.maven.surefire.plugin>
<version.maven.deploy.plugin>3.1.2</version.maven.deploy.plugin>
<version.maven.site.plugin>3.12.1</version.maven.site.plugin>
<version.maven.dependency.plugin>3.6.1</version.maven.dependency.plugin>
<version.maven.jar.plugin>3.4.1</version.maven.jar.plugin>
<version.maven.remote.resources.plugin>3.2.0</version.maven.remote.resources.plugin>
<version.maven.clean.plugin>3.4.0</version.maven.clean.plugin>
<!-- Plugins version -->
<!-- Before adding a new Plugin version, please check if the "apache" parent POM defines it -->
<version.codehaus.flatten.plugin>1.6.0</version.codehaus.flatten.plugin>

<!-- Config -->
Expand Down Expand Up @@ -159,7 +149,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-site-plugin</artifactId>
<version>${version.maven.site.plugin}</version>
<dependencies>
<dependency>
<groupId>org.apache.commons</groupId>
Expand All @@ -176,7 +165,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-remote-resources-plugin</artifactId>
<version>${version.maven.remote.resources.plugin}</version>
<dependencies>
<dependency>
<groupId>org.apache.commons</groupId>
Expand All @@ -193,7 +181,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<version>${version.maven.jar.plugin}</version>
<dependencies>
<dependency>
<groupId>org.iq80.snappy</groupId>
Expand All @@ -205,7 +192,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>${version.maven.surefire.plugin}</version>
<dependencies>
<dependency>
<groupId>org.iq80.snappy</groupId>
Expand Down Expand Up @@ -237,14 +223,12 @@
</plugin>
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
<version>${version.maven.compiler.plugin}</version>
<configuration>
<parameters>${maven.compiler.parameters}</parameters>
</configuration>
</plugin>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
<version>${version.maven.surefire.plugin}</version>
<configuration>
<systemPropertyVariables>
<java.util.logging.manager>org.jboss.logmanager.LogManager</java.util.logging.manager>
Expand Down
19 changes: 9 additions & 10 deletions packages/dev-deployment-kogito-quarkus-blank-app/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,19 +41,18 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>

<!-- Maven versions -->
<version.maven.artifact.plugin>3.4.1</version.maven.artifact.plugin>
<!-- Plugins version -->
<version.codehaus.flatten.plugin>1.6.0</version.codehaus.flatten.plugin>
<version.maven.clean.plugin>3.4.0</version.maven.clean.plugin>
<version.maven.compiler.plugin>3.13.0</version.maven.compiler.plugin>
<version.maven.resources.plugin>3.3.1</version.maven.resources.plugin>
<version.maven.failsafe.plugin>3.0.0-M7</version.maven.failsafe.plugin>
<version.maven.surefire.plugin>3.5.0</version.maven.surefire.plugin>
<version.maven.install.plugin>3.1.3</version.maven.install.plugin>
<version.maven.dependency.plugin>3.7.1</version.maven.dependency.plugin>
yesamer marked this conversation as resolved.
Show resolved Hide resolved
<version.maven.deploy.plugin>3.1.2</version.maven.deploy.plugin>
yesamer marked this conversation as resolved.
Show resolved Hide resolved
<version.maven.failsafe.plugin>${version.maven.surefire.plugin}</version.maven.failsafe.plugin>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, this sounds a little bit non-standard to me, is that intentional to combine failsafe and surefire versions? furthermore version.maven.failsafe.plugin seems to be unused

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jomarko Yes, that's correct. failsafe and surefire have the same release cycle. apache pom manages that in the same way: https://repo.maven.apache.org/maven2/org/apache/apache/32/apache-32.pom

<version.maven.install.plugin>3.1.3</version.maven.install.plugin>
yesamer marked this conversation as resolved.
Show resolved Hide resolved
<version.maven.jar.plugin>3.4.2</version.maven.jar.plugin>
<version.maven.resources.plugin>3.3.1</version.maven.resources.plugin>
<version.maven.site.plugin>3.21.0</version.maven.site.plugin>
<version.maven.dependency.plugin>3.6.1</version.maven.dependency.plugin>
<version.maven.jar.plugin>3.4.1</version.maven.jar.plugin>
<version.maven.clean.plugin>3.4.0</version.maven.clean.plugin>
<version.codehaus.flatten.plugin>1.6.0</version.codehaus.flatten.plugin>
<version.maven.surefire.plugin>3.5.0</version.maven.surefire.plugin>
<!-- Temporary declaring xstream dependency, a version (1.4.20) is transitively imported by Quarkus 3.8 affected by CVE
When upgrading Quarkus (> 3.15.x) to a new version, please evaluate if this exclusion can be removed -->
<version.com.thoughtworks.xstream>1.4.21</version.com.thoughtworks.xstream>
Expand Down
2 changes: 1 addition & 1 deletion packages/extended-services/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
<version>32</version>
<version>33</version>
</parent>

<modelVersion>4.0.0</modelVersion>
Expand Down
76 changes: 4 additions & 72 deletions packages/maven-base/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
<version>32</version>
<version>33</version>
</parent>

<groupId>org.kie</groupId>
Expand Down Expand Up @@ -105,22 +105,10 @@
<project.build.outputTimestamp>2024-01-12T00:00:00Z</project.build.outputTimestamp>
<maven.compiler.parameters>true</maven.compiler.parameters>

<!-- Maven versions -->
<version.maven.artifact.plugin>3.4.1</version.maven.artifact.plugin>
<version.maven.compiler.plugin>3.13.0</version.maven.compiler.plugin>
<version.maven.resources.plugin>3.2.0</version.maven.resources.plugin>
<version.maven.failsafe.plugin>3.0.0-M7</version.maven.failsafe.plugin>
<version.maven.surefire.plugin>3.5.0</version.maven.surefire.plugin>
<version.maven.install.plugin>3.1.3</version.maven.install.plugin>
<version.maven.helper.plugin>3.2.0</version.maven.helper.plugin>
<version.maven.deploy.plugin>3.1.2</version.maven.deploy.plugin>
<version.maven.site.plugin>3.12.1</version.maven.site.plugin>
<version.maven.source.plugin>3.3.1</version.maven.source.plugin>
<version.maven.dependency.plugin>3.6.1</version.maven.dependency.plugin>
<version.maven.jar.plugin>3.4.1</version.maven.jar.plugin>
<version.maven.remote.resources.plugin>3.2.0</version.maven.remote.resources.plugin>
<version.maven.clean.plugin>3.4.0</version.maven.clean.plugin>
<!-- Plugins version -->
<!-- Before adding a new Plugin version, please check if the "apache" parent POM defines it -->
<version.codehaus.flatten.plugin>1.6.0</version.codehaus.flatten.plugin>
<version.maven.artifact.plugin>3.5.3</version.maven.artifact.plugin>

<!-- Apache KIE -->
<version.org.kie.kogito>999-20241208-SNAPSHOT</version.org.kie.kogito>
Expand Down Expand Up @@ -283,61 +271,6 @@
>${session.executionRootDirectory}/node_modules/@kie-tools/maven-base/not-reproducible-plugins.properties</pluginIssues>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-install-plugin</artifactId>
<version>${version.maven.install.plugin}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-deploy-plugin</artifactId>
<version>${version.maven.deploy.plugin}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-helper-plugin</artifactId>
<version>${version.maven.helper.plugin}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<version>${version.maven.dependency.plugin}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>${version.maven.compiler.plugin}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-failsafe-plugin</artifactId>
<version>${version.maven.failsafe.plugin}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-clean-plugin</artifactId>
<version>${version.maven.clean.plugin}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>${version.maven.surefire.plugin}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<version>${version.maven.jar.plugin}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<version>${version.maven.source.plugin}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-remote-resources-plugin</artifactId>
<version>${version.maven.remote.resources.plugin}</version>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>flatten-maven-plugin</artifactId>
Expand Down Expand Up @@ -442,7 +375,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-install-plugin</artifactId>
<version>${version.maven.install.plugin}</version>
<configuration>
<skip>true</skip>
</configuration>
Expand Down
2 changes: 1 addition & 1 deletion packages/serverless-logic-web-tools-swf-deployment-quarkus-app/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
<version>32</version>
<version>33</version>
</parent>

<modelVersion>4.0.0</modelVersion>
Expand Down
8 changes: 4 additions & 4 deletions packages/serverless-workflow-diagram-editor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@
],
"scripts": {
"build:dev": "run-script-os",
"build:dev:linux:darwin": "mvn clean install -DskipTests -DskipITs -Pno-showcase",
"build:dev:win32": "pnpm powershell \"mvn clean install `-DskipTests `-DskipITs `-Pno-showcase\"",
"build:dev:linux:darwin": "mvn clean install -DskipTests -DskipITs",
"build:dev:win32": "pnpm powershell \"mvn clean install `-DskipTests `-DskipITs\"",
"build:prod": "run-script-os",
"build:prod:linux:darwin": "pnpm lint && mvn clean install -DskipTests=$(build-env tests.run --not) -Dmaven.test.failure.ignore=$(build-env tests.ignoreFailures) -DskipITs=$(build-env endToEndTests.run --not) -Pno-showcase",
"build:prod:win32": "pnpm lint && pnpm powershell \"mvn clean install `-DskipTests=$(build-env tests.run --not) `-Dmaven.test.failure.ignore=$(build-env tests.ignoreFailures) `-DskipITs=$(build-env endToEndTests.run --not) `-Pno-showcase\"",
"build:prod:linux:darwin": "pnpm lint && mvn clean install -DskipTests=$(build-env tests.run --not) -Dmaven.test.failure.ignore=$(build-env tests.ignoreFailures) -DskipITs=$(build-env endToEndTests.run --not)",
"build:prod:win32": "pnpm lint && pnpm powershell \"mvn clean install `-DskipTests=$(build-env tests.run --not) `-Dmaven.test.failure.ignore=$(build-env tests.ignoreFailures) `-DskipITs=$(build-env endToEndTests.run --not)\"",
"install": "node install.js",
"lint": "echo 'Linting'",
"powershell": "@powershell -NoProfile -ExecutionPolicy Unrestricted -Command"
Expand Down
24 changes: 12 additions & 12 deletions packages/serverless-workflow-diagram-editor/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,28 +160,28 @@
<version.antrun.plugin>1.8</version.antrun.plugin>
<version.buildhelper.plugin>3.0.0</version.buildhelper.plugin>
<version.bundle.plugin>3.3.0</version.bundle.plugin>
<version.checkstyle.plugin>3.2.0</version.checkstyle.plugin>
<version.clean.plugin>3.1.0</version.clean.plugin>
<version.compiler.plugin>3.12.1</version.compiler.plugin>
<version.dependency.plugin>3.3.0</version.dependency.plugin>
<version.deploy.plugin>2.8.2</version.deploy.plugin>
<version.enforcer.plugin>3.1.0</version.enforcer.plugin>
<version.checkstyle.plugin>3.4.0</version.checkstyle.plugin>
<version.clean.plugin>3.4.0</version.clean.plugin>
<version.compiler.plugin>3.13.0</version.compiler.plugin>
<version.dependency.plugin>3.7.1</version.dependency.plugin>
<version.deploy.plugin>3.1.2</version.deploy.plugin>
<version.enforcer.plugin>3.5.0</version.enforcer.plugin>
<version.failsafe.plugin>${version.surefire.plugin}</version.failsafe.plugin>
<version.install.plugin>2.5.2</version.install.plugin>
<version.install.plugin>3.1.2</version.install.plugin>
<version.jacoco.plugin>0.8.11</version.jacoco.plugin>
<version.jar.plugin>3.1.0</version.jar.plugin>
<version.jarjar.plugin>1.5</version.jarjar.plugin>
<version.javadoc.plugin>3.0.1</version.javadoc.plugin>
<version.org.kie.gwthelper.maven>1.3</version.org.kie.gwthelper.maven>
<version.replacer.plugin>1.5.2</version.replacer.plugin>
<version.resources.plugin>3.2.0</version.resources.plugin>
<version.shade.plugin>3.2.1</version.shade.plugin>
<version.site.plugin>3.7.1</version.site.plugin>
<version.resources.plugin>3.3.1</version.resources.plugin>
<version.shade.plugin>3.6.0</version.shade.plugin>
<version.site.plugin>3.12.1</version.site.plugin>
<version.spotbugs-maven-plugin>3.1.8</version.spotbugs-maven-plugin>
<version.sonar.plugin>3.9.1.2184</version.sonar.plugin>
<version.source.plugin>3.3.1</version.source.plugin>
<version.surefire.plugin>3.2.5</version.surefire.plugin>
<version.war.plugin>3.2.2</version.war.plugin>
<version.surefire.plugin>3.3.0</version.surefire.plugin>
<version.war.plugin>3.4.0</version.war.plugin>
<version.zanata.plugin>2.3.0</version.zanata.plugin>

<!-- Third party Libraries -->
Expand Down
24 changes: 12 additions & 12 deletions packages/stunner-editors/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,29 +187,29 @@
<version.antrun.plugin>1.8</version.antrun.plugin>
<version.buildhelper.plugin>3.0.0</version.buildhelper.plugin>
<version.bundle.plugin>3.3.0</version.bundle.plugin>
<version.checkstyle.plugin>3.2.0</version.checkstyle.plugin>
<version.clean.plugin>3.1.0</version.clean.plugin>
<version.compiler.plugin>3.12.1</version.compiler.plugin>
<version.dependency.plugin>3.3.0</version.dependency.plugin>
<version.deploy.plugin>2.8.2</version.deploy.plugin>
<version.enforcer.plugin>3.1.0</version.enforcer.plugin>
<version.checkstyle.plugin>3.4.0</version.checkstyle.plugin>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is expected dashbuilder overrides to 3.1.1? I think preferred would be single version everywhere if possible

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I purposely didn't touch dashbuilder because is not a project under our control, however, I can do a tentative

Copy link
Contributor Author

@yesamer yesamer Dec 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jomarko Updated versions in dashbuilder as well, thank you!

<version.clean.plugin>3.4.0</version.clean.plugin>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above

<version.compiler.plugin>3.13.0</version.compiler.plugin>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above

<version.dependency.plugin>3.7.1</version.dependency.plugin>
<version.deploy.plugin>3.1.2</version.deploy.plugin>
<version.enforcer.plugin>3.5.0</version.enforcer.plugin>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above

<version.failsafe.plugin>${version.surefire.plugin}</version.failsafe.plugin>
<version.install.plugin>2.5.2</version.install.plugin>
<version.install.plugin>3.1.2</version.install.plugin>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version misalignment is also for:

  • version.maven.artifact.plugin
  • version.resources.plugin
  • version.site.plugin
  • version.surefire.plugin
  • version.war.plugin

<version.jacoco.plugin>0.8.11</version.jacoco.plugin>
<version.jar.plugin>3.1.0</version.jar.plugin>
<version.jarjar.plugin>1.5</version.jarjar.plugin>
<version.org.jvnet.jaxb2.maven2.maven-jaxb2-plugin>0.15.1</version.org.jvnet.jaxb2.maven2.maven-jaxb2-plugin>
<version.org.kie.gwthelper.maven>1.3</version.org.kie.gwthelper.maven>
<version.org.kogito.gwt-jsonix-schema-compiler>1.3.0</version.org.kogito.gwt-jsonix-schema-compiler>
<version.replacer.plugin>1.5.2</version.replacer.plugin>
<version.resources.plugin>3.2.0</version.resources.plugin>
<version.shade.plugin>3.2.1</version.shade.plugin>
<version.site.plugin>3.7.1</version.site.plugin>
<version.resources.plugin>3.3.1</version.resources.plugin>
<version.shade.plugin>3.6.0</version.shade.plugin>
<version.site.plugin>3.12.1</version.site.plugin>
<version.spotbugs-maven-plugin>3.1.8</version.spotbugs-maven-plugin>
<version.sonar.plugin>3.9.1.2184</version.sonar.plugin>
<version.source.plugin>3.3.1</version.source.plugin>
<version.surefire.plugin>3.2.5</version.surefire.plugin>
<version.war.plugin>3.2.2</version.war.plugin>
<version.surefire.plugin>3.3.0</version.surefire.plugin>
<version.war.plugin>3.4.0</version.war.plugin>
<version.zanata.plugin>2.3.0</version.zanata.plugin>

<!-- Third party Libraries -->
Expand Down
Loading