Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kie-issues#1718: DMN Editor extension generates SVG with missing font color #2816

Merged
merged 2 commits into from
Dec 17, 2024
Merged

kie-issues#1718: DMN Editor extension generates SVG with missing font color #2816

merged 2 commits into from
Dec 17, 2024

Conversation

Kusuma04-dev
Copy link
Contributor

@Kusuma04-dev Kusuma04-dev commented Dec 16, 2024 •
edited by yesamer
Loading

Closes apache/incubator-kie-issues#1718

Fixing font-color issue while downloading SVG in DMN Editor.

@Kusuma04-dev Kusuma04-dev changed the title fixing font color issue while downloading svg DMN Editor extension generates SVG with missing font color Dec 16, 2024
@yesamer yesamer changed the title DMN Editor extension generates SVG with missing font color kie-issues#1718: DMN Editor extension generates SVG with missing font color Dec 16, 2024
@yesamer
Copy link
Contributor

yesamer commented Dec 16, 2024

@Kusuma04-dev Thank you and congratulations on your first contribution! Do you have any screenshots to share to see your change in action?

@kbowers-ibm kbowers-ibm self-requested a review December 16, 2024 14:24
kbowers-ibm
kbowers-ibm requested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@kbowers-ibm kbowers-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kusuma, congrats on your first PR! It looks great, and more importantly, it works, so nicely done! As Yeser mentioned, it can be helpful to include a screenshot, e.g. a before and after showing your change working, especially with a visual bug like this. Just a minor comment from me regarding clean-code practices

packages/dmn-editor/src/svg/DmnDiagramSvg.tsx Outdated Show resolved Hide resolved
@jomarko
Copy link
Contributor

jomarko commented Dec 16, 2024

Will do review once #2816 (comment) is discussed. Right now I am not sure if code will change or not.

@Kusuma04-dev
Copy link
Contributor Author

Kusuma04-dev commented Dec 17, 2024 •
edited
Loading

@Kusuma04-dev Thank you and congratulations on your first contribution! Do you have any screenshots to share to see your change in action?
DMN diagram:

Screenshot 2024-12-17 at 10 09 51 AM

SVG before fix:
Screenshot 2024-12-17 at 10 06 37 AM

SVG after fix:
Screenshot 2024-12-17 at 10 07 14 AM

jomarko
jomarko approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the feature works now well. Thank you for the fix.

kbowers-ibm
kbowers-ibm approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@kbowers-ibm kbowers-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kusuma, looks good to me!

yesamer
yesamer approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Kusuma04-dev

@yesamer yesamer merged commit d80fa2b into apache:main Dec 17, 2024
15 checks passed
rhkp pushed a commit to rhkp/incubator-kie-tools that referenced this pull request Dec 17, 2024
@Kusuma04-dev @rhkp
kie-issues#1718: DMN Editor extension generates SVG with missing font…
0109657 
… color (apache#2816)

Co-authored-by: chinnamatli kusumalatha <[email protected]>
@Kusuma04-dev Kusuma04-dev deleted the kie-issues#1718 branch December 20, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbowers-ibm kbowers-ibm kbowers-ibm approved these changes

@yesamer yesamer yesamer approved these changes

@jomarko jomarko jomarko approved these changes

@tiagobento tiagobento Awaiting requested review from tiagobento tiagobento is a code owner

@ljmotta ljmotta Awaiting requested review from ljmotta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DMN Editor extension generates SVG with missing font color
4 participants
@Kusuma04-dev @yesamer @jomarko @kbowers-ibm