-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kie-issues#1669: jBPM Quarkus DevUI seems to not update the # of items #2814
base: main
Are you sure you want to change the base?
Conversation
…ols into kie-issues#1669
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bncriju great work! I cannot get the counts initialized to 0
the first time I open Dev UI for first time (they stay as -
). Would you mind taking a look?
case "JobEvent": | ||
maybeRun(onJobEvent); | ||
break; | ||
default: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can get rid of the default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
} | ||
|
||
public void refresh() { | ||
vertx.setTimer(500, id -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This timer looks like to short, in slow laptops (like main) this may not work, but I think we can go with it for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done and adjusted to 1000 instead of 500
Thanks for the comments @pefernan. Still cannot get the counts initialized to 0 the first time I open Dev UI for first time (they stay as -), but this works fine as expected when we open process-compact-architecture. |
The wrong behavior is rectified by making the Process Instances, Tasks and Jobs to get dynamically updated, as and when user defines a process instance.
Closes apache/incubator-kie-issues#1669
Please note that earlier pull request got auto closed while renamed the branch name to match the correct kie-issue and the comments in the previous pull request are already incorporated in this one.