kie-issues#1669: jBPM Quarkus DevUI seems to not update the # of items #2814
Conversation
…ols into kie-issues#1669
| case "JobEvent": | ||
| maybeRun(onJobEvent); | ||
| break; | ||
| default: |
There was a problem hiding this comment.
maybe we can get rid of the default
| } | ||
|
|
||
| public void refresh() { | ||
| vertx.setTimer(500, id -> { |
There was a problem hiding this comment.
This timer looks like to short, in slow laptops (like main) this may not work, but I think we can go with it for now.
There was a problem hiding this comment.
Done and adjusted to 1000 instead of 500
|
Thanks for the comments @pefernan. Still cannot get the counts initialized to 0 the first time I open Dev UI for first time (they stay as -), but this works fine as expected when we open process-compact-architecture. |
…d Expression Editor (apache#2681) Co-authored-by: Luiz João Motta <[email protected]>
…les/kie-sandbox-commit-message-validation-service (apache#2812)
…n e2e tests (apache#2818) Signed-off-by: Ricardo Zanini <[email protected]>
…omatic change of platform images based on env context (apache#2794) Signed-off-by: Ricardo Zanini <[email protected]> Signed-off-by: Ricardo Zanini <[email protected]>
…eId each timer belongs to (apache#2820) Co-authored-by: Pere Fernández <[email protected]>
|
Done all the changes, and could you have a review once again |
| } | ||
|
|
||
| private void refreshCount() { | ||
| LOGGER.info("Refreshing data for query: {}", query); |
There was a problem hiding this comment.
@bncriju I'd change this to debug to have the logs a bit more clean
...quarkus-devui-runtime/src/main/java/org/jbpm/quarkus/devui/runtime/rpc/DataIndexCounter.java
Outdated
Show resolved
Hide resolved
|
Good job, @bncriju ! I just found some minor issues in the jbpm-dev-ui:
I don't know if this is an issue, but I think it doesn't looks correct. It can be an issue related to filters in tasks either. I'm not sure. What do you think @pefernan ? |
|
@danielzhe yes, issue 1 is something I already found. Looks like the new subscriptions added to the counter Multi aren't updated with the new values.. I provided @bncriju a PR with a fix (bncriju#2) Regarding 2.. yes, that's a filter thing, we are currently showing the count of all elements (process instances, tasks or jobs) indexed in data-index. When we first created we wanted to show a snapshot of what was present on the system, but we can definitelly change it. In the end I think that it's just matter of deciding what we want to display there, I don't have a strong opinion. |
- Adding `MultiCacheOp` to automatically replying emitted data to new subscribers
…ols into kie-issues#1669
|
thanks Pere and Daniel for all the inputs and suggestions on this. now, in good position to merge seeing the ci build status. |
|
Merging, the failing 'CI :: License headers' is unrelated and already fixed. |
The wrong behavior is rectified by making the Process Instances, Tasks and Jobs to get dynamically updated, as and when user defines a process instance.
Closes apache/incubator-kie-issues#1669
Please note that earlier pull request got auto closed while renamed the branch name to match the correct kie-issue and the comments in the previous pull request are already incorporated in this one.