-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kie-issues#1647 [kn-plugin-workflow] Executing kn workflow run creates the container in the background #2778
base: main
Are you sure you want to change the base?
Conversation
3553cf3
to
373d4fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have e2e in place?
This one ?
As I understand from domhanak, there is no need to add tests for the current case. |
Not sure if it is feasible here, The test would need to check whether after the test is done, there is no container image running in docker/podman |
That's why I asked for an e2e infra/framework. We can't reliably test it without such a structure. |
hmm:
|
I pushed the failed job again, @treblereel |
@treblereel Can you please adjust the PR title? Missing ticket reference and the title is cut off too. Thanks! |
…in the background (cherry picked from commit 9dda668)
6e2ee59
to
d5a7ca0
Compare
Closes apache/incubator-kie-issues#1647