Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#1647 [kn-plugin-workflow] Executing kn workflow run creates the container in the background #2778

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

treblereel
Copy link
Contributor

@treblereel treblereel commented Nov 30, 2024

@treblereel treblereel self-assigned this Nov 30, 2024
@treblereel treblereel force-pushed the apache_issues_1647 branch 5 times, most recently from 3553cf3 to 373d4fa Compare December 2, 2024 05:39
@treblereel treblereel requested a review from domhanak December 2, 2024 07:51
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have e2e in place?

@treblereel
Copy link
Contributor Author

Do we have e2e in place?

This one ?

var cfgTestInputRun_Success = []cfgTestInputRun{

As I understand from domhanak, there is no need to add tests for the current case.

@domhanak
Copy link
Contributor

domhanak commented Dec 3, 2024

Not sure if it is feasible here, The test would need to check whether after the test is done, there is no container image running in docker/podman

@ricardozanini
Copy link
Member

Not sure if it is feasible here, The test would need to check whether after the test is done, there is no container image running in docker/podman

That's why I asked for an e2e infra/framework. We can't reliably test it without such a structure.

@treblereel
Copy link
Contributor Author

hmm:

Error: s/sonataflow-builder-image build:dev: 2024-12-06 00:17:06,181 docker_builder.py:107        INFO  Docker: [ERROR] Failed to execute goal on project serverless-workflow-project: Could not resolve dependencies for project org.acme:serverless-workflow-project:jar:1.0.0-SNAPSHOT: Failed to collect dependencies at org.apache.kie.sonataflow:sonataflow-quarkus:jar:999-20241016-SNAPSHOT -> org.kie.kogito:kogito-jq-expression:jar:999-20241016-SNAPSHOT: Failed to read artifact descriptor for org.kie.kogito:kogito-jq-expression:jar:999-20241016-SNAPSHOT: Could not transfer artifact org.kie.kogito:kogito-jq-expression:pom:999-20241016-20241016.204815-1 from/to apache.snapshots (https://repository.apache.org/snapshots): transfer failed for https://repository.apache.org/snapshots/org/kie/kogito/kogito-jq-expression/999-20241016-SNAPSHOT/kogito-jq-expression-999-20241016-20241016.204815-1.pom: Connect to repository.apache.org:443 [repository.apache.org/65.109.119.155] failed: Connection timed out -> [Help 1]

@ricardozanini
Copy link
Member

I pushed the failed job again, @treblereel

@tiagobento
Copy link
Contributor

@treblereel Can you please adjust the PR title? Missing ticket reference and the title is cut off too. Thanks!

@treblereel treblereel changed the title [kn-plugin-workflow] Executing kn workflow run creates the container … kie-issues#1647 [kn-plugin-workflow] Executing kn workflow run creates the container in the background Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kn-plugin-workflow] Executing kn workflow run creates the container in the background
4 participants