kie-issues#1526: [kn-plugin-workflow] kn-workflow-plugin should persist workflow in the docker image #2725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeap, We have to include workflow.sw into the docker image, so have to modify docker files |
ricardozanini
approved these changes
Nov 6, 2024
domhanak
reviewed
Jan 16, 2025
| @@ -0,0 +1,16 @@ | |||
| FROM registry.access.redhat.com/ubi8/openjdk-17:1.18 | |||
There was a problem hiding this comment.
Could this be parametrized? just a nitpick, disregard if not
domhanak
reviewed
Jan 16, 2025
| @@ -0,0 +1,11 @@ | |||
| FROM registry.access.redhat.com/ubi8/ubi-minimal:8.9 | |||
There was a problem hiding this comment.
Could this be parametrized? just a nitpick, disregard if not
There was a problem hiding this comment.
@domhanak Actually, this is only needed for testing; there's no need to keep the current version, any version will work.
domhanak
approved these changes
Jan 16, 2025
domhanak
requested changes
Jan 16, 2025
There was a problem hiding this comment.
@treblereel please, let's rebase to ensure we are not missing some headers. This is quite old PR
domhanak
approved these changes
Jan 16, 2025
treblereel
force-pushed
the
issue_1526
branch
from
eca7fdd to
b75df24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: apache/incubator-kie-issues#1526
this issue is related to apache/incubator-kie-kogito-serverless-operator#405