Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kie-issues#1526: [kn-plugin-workflow] kn-workflow-plugin should persist workflow in the docker image #2725

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

kie-issues#1526: [kn-plugin-workflow] kn-workflow-plugin should persist workflow in the docker image #2725

wants to merge 3 commits into from

Conversation

treblereel
Copy link
Contributor

@treblereel treblereel self-assigned this Nov 5, 2024
ricardozanini
ricardozanini reviewed Nov 5, 2024
View reviewed changes
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, are we manipulating the Quarkus auto-generated Dockerfile to add the files we need to pass the validation on the operator side?

@treblereel
Copy link
Contributor Author

treblereel commented Nov 5, 2024 •
edited
Loading

So, are we manipulating the Quarkus auto-generated Dockerfile to add the files we need to pass the validation on the operator side?

yeap, We have to include workflow.sw into the docker image, so have to modify docker files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

@tiagobento tiagobento Awaiting requested review from tiagobento tiagobento is a code owner

@domhanak domhanak Awaiting requested review from domhanak

Assignees

@treblereel treblereel

Labels
area:sonataflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treblereel @ricardozanini