kie-issues#1595: Sandbox: Add "Open in Boxed Expression Editor" button in the DMN Runner form output cards #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n in the DMN Runner form output cards Closes: apache/incubator-kie-issues#1595
tiagobento
reviewed
Dec 19, 2024
| @@ -51,6 +51,7 @@ export interface EditorInitArgs { | |||
|
|
|||
| export interface KogitoEditorEnvelopeApi extends KeyboardShortcutsEnvelopeApi, I18nEnvelopeApi { | |||
| kogitoEditor_contentChanged(content: EditorContent, args: { showLoadingOverlay: boolean }): Promise<void>; | |||
| kogitoEditor_openBoxedExpressionEditor(nodeId: string): void; | |||
There was a problem hiding this comment.
This method is specific to the DMN Editor so shouldn't be here in the generic Editor's interface.
There was a problem hiding this comment.
yes, thank you @tiagobento , @ljmotta gave me a tip to look on:
YardChannelComponentWebToolsEmbeddedEditoryardTextEditor_moveCursorToPosition
working on it currently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: apache/incubator-kie-issues#1595
TODO
EditorEnvelope.initoccurrencesThis PR adds a button for opening the boxed expression editor for the desired decision node from the DMN Runner form. See the button
Open New Decision expressionin the screenshot below.