Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kie-issues#1547: DMN Editor: Render evaluation highlights in the Boxed Expression Editor #2681
kie-issues#1547: DMN Editor: Render evaluation highlights in the Boxed Expression Editor #2681
Changes from 6 commits
19bd400
713e27d
d99ef6a
262e4b5
f2274d0
84a6a46
527aad4
925f925
22270b1
b2bf4a9
d7b4635
22996a0
0ec93a0
6e4ea9b
19e8b23
d52e553
4312521
d5194b2
3991237
4ca0587
080f4cd
1fe7f31
156db3e
8b20094
f1f356e
7ce7cdc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why
1
? Could you please add a comment here? Or make it a variable with a very good name.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed from the codebase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get the
0
here, but it would be good to add a comment too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed from the codebase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first-child
here was my decision to use, otherwise there is problem, whenthen
/else
branch has nested decision table, but not all decision table rules were evaluated. see: