Address review comments

apache · Jan 10, 2025 · 3cea124 · 3cea124
1 parent 911dc62
commit 3cea124
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/packages/kogito-db-migrator-tool-image/package.json b/packages/kogito-db-migrator-tool-image/package.json
@@ -13,7 +13,7 @@
     "url": "https://github.com/apache/incubator-kie-tools/issues"
   },
   "scripts": {
-    "build": ". ./node_modules/@kie-tools/python-venv/venv/bin/activate && pnpm copy-assets && pnpm image:build && rimraf target && rimraf dist-tests-e2e",
+    "build": "run-script-if --bool \"$(build-env containerImages.build)\" --then \"pnpm venv-activate\" \"pnpm copy-assets\" \"pnpm image:build\" \"rimraf target\" \"rimraf dist-tests-e2e\"",
     "build:dev": "run-script-os",
     "build:dev:linux": "pnpm build",
     "build:dev:win32:darwin": "echo \"Build skipped on Windows and MacOS\"",
@@ -27,7 +27,8 @@
     "image:build:linux": "pnpm setup:env make -C ./build build",
     "image:build:win32:darwin": "echo \"Build skipped on Windows and MacOS\"",
     "install": "node install.js && pnpm format",
-    "setup:env": ". ./node_modules/@kie-tools/python-venv/venv/bin/activate && cross-env KOGITO_IMAGE_REGISTRY=$(build-env kogitoDbMigratorToolImage.registry) KOGITO_IMAGE_REGISTRY_ACCOUNT=$(build-env kogitoDbMigratorToolImage.account) KOGITO_IMAGE_NAME=$(build-env kogitoDbMigratorToolImage.name) KOGITO_IMAGE_TAG=$(build-env kogitoDbMigratorToolImage.buildTag) QUARKUS_PLATFORM_GROUPID=$(build-env kogitoImagesCekitModules.quarkusGroupId) QUARKUS_PLATFORM_VERSION=$(build-env versions.quarkus) KOGITO_VERSION=$(build-env versions.kogito)"
+    "setup:env": ". ./node_modules/@kie-tools/python-venv/venv/bin/activate && cross-env KOGITO_IMAGE_REGISTRY=$(build-env kogitoDbMigratorToolImage.registry) KOGITO_IMAGE_REGISTRY_ACCOUNT=$(build-env kogitoDbMigratorToolImage.account) KOGITO_IMAGE_NAME=$(build-env kogitoDbMigratorToolImage.name) KOGITO_IMAGE_TAG=$(build-env kogitoDbMigratorToolImage.buildTag) QUARKUS_PLATFORM_GROUPID=$(build-env kogitoImagesCekitModules.quarkusGroupId) QUARKUS_PLATFORM_VERSION=$(build-env versions.quarkus) KOGITO_VERSION=$(build-env versions.kogito)",
+    "venv-activate": ". ./node_modules/@kie-tools/python-venv/venv/bin/activate"
   },
   "dependencies": {
     "@kie-tools/kogito-db-migrator-tool": "workspace:*",