Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#376 - E2E tests are failing in nightly deploy job #384

Merged
merged 8 commits into from
Feb 12, 2024

Conversation

domhanak
Copy link
Contributor

@domhanak domhanak commented Feb 5, 2024

Fixes #376

Description of the change:
Change Jenkinsfile.e2e.cluster to run with Kind cluster by default

Currently it is structured in a not ideal way, suggestions are welcome

It is not the goal to remove minikube related files in this PR.

Motivation for the change:
Recent switch in PR checks to Kind

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?

@domhanak domhanak requested a review from jstastny-cz as a code owner February 5, 2024 11:54
@domhanak domhanak requested review from jakubschwan and removed request for jstastny-cz February 5, 2024 11:54
.ci/jenkins/Jenkinsfile.e2e.cluster Show resolved Hide resolved
.ci/jenkins/Jenkinsfile.e2e.cluster Outdated Show resolved Hide resolved
.ci/jenkins/scripts/kind.groovy Outdated Show resolved Hide resolved
@domhanak domhanak force-pushed the kso-issue-376 branch 4 times, most recently from a97ad7a to ca3e9e2 Compare February 5, 2024 16:38
Copy link
Contributor

@jstastny-cz jstastny-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@domhanak
Copy link
Contributor Author

domhanak commented Feb 6, 2024

Please hold the merge I will link a successful run after this update, before merging to ensure this works.

@domhanak domhanak force-pushed the kso-issue-376 branch 2 times, most recently from ef3419d to f010909 Compare February 6, 2024 18:54
@domhanak
Copy link
Contributor Author

domhanak commented Feb 6, 2024

@jstastny-cz redone using make to match it with ghactions workflow.

Note that I have commits that edit helper.checkoutRepo() to work on test folder in apache jenkins, will remove once I see a green run. Currently the tests are experiencing timeouts.

@domhanak domhanak force-pushed the kso-issue-376 branch 2 times, most recently from 68de5d3 to 37f392e Compare February 7, 2024 09:38
@ricardozanini
Copy link
Member

@domhanak can you regen your files? Looks like you're still working on this PR. Is it worth changing to draft instead so we can review once it's done?

@domhanak
Copy link
Contributor Author

domhanak commented Feb 7, 2024

Sure, I am investigating the issues on CI, this does not work there properly there, and the reason is yet unknown

@domhanak domhanak marked this pull request as draft February 7, 2024 13:34
See comment, GHA nodes behave different to Apache CI.
Temporary workaround for this
@domhanak
Copy link
Contributor Author

domhanak commented Feb 8, 2024

Green run:
https://ci-builds.apache.org/job/KIE/job/test/job/dhanak/job/kogito-serverless-operator.e2e.minikube-test/46/

Please take a look, keep in mind we are migrating to BDD tests in the meantime so only thing that really matters here is for this to be stable until we switch.

@domhanak domhanak marked this pull request as ready for review February 9, 2024 13:04
@domhanak
Copy link
Contributor Author

domhanak commented Feb 9, 2024

Follow up issue:
#390

@domhanak
Copy link
Contributor Author

domhanak commented Feb 9, 2024

@jstastny-cz
Copy link
Contributor

@domhanak ready for final reviews?

@domhanak domhanak requested review from jakubschwan and removed request for jakubschwan February 9, 2024 14:14
@ricardozanini ricardozanini merged commit 3b98ccd into apache:main Feb 12, 2024
4 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-serverless-operator that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E tests are failing in nightly deploy job
3 participants