Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Prometheus ServiceMonitor object that can capture/collect metrics from deployed SonataFlow instances #464

Closed
Tracked by #461
ricardozanini opened this issue May 13, 2024 · 1 comment · Fixed by #540
Assignees
Labels
enhancement New feature or request

Comments

@ricardozanini
Copy link
Member

ricardozanini commented May 13, 2024

Description

The operator can track in the cluster if Prometheus Operator is installed. If this condition is true and the SonataFlowPlatform is marked with .spec.monitoring: true, then each workflow instance can have a ServiceMonitor object bound to it.

Implementation ideas

Each SonataFlow already exposes a Service. Hence, in this issue, it's expected that each ServiceMonitor instance binds to it.

Verify with kogito-runtimes the endpoints to scrap for metrics (should be /metrics).

Prereqs

  • Prometheus operator is installed
  • Prometheus CR is already deployed and configured in the cluster. The operator won't provision a Prometheus server.
@jianrongzhang89
Copy link
Contributor

We decided to modify the scope for this issue so that the operator only creates a service monitor for workflows deployed as k8s deployments. A separate issue has been created to track the work for workflows deployed as Knative services:
#550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🎯 Done
2 participants