-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPIC - Add the possibility to integrate the Operator with Prometheus and Grafana #461
Comments
As a sonataflow operator user, I should be able to enable a monitoring flag via the SonataFlowPlatform CR, which will result in creating the required software components.
|
@JudeNiroshan can you formulate on this request?
The operator won't be responsible for installing third-party operators in a cluster. The reason is that we won't add administrative permissions to the operator such as installing CRDs. Also, installing an operator comes with many configuration options. So it's highly complex to add an interface and wrappers around these installation procedures that can change from time to time when a new operator version is released.
This is fine. We can certainly try to check if these CRDs are available in the cluster and create CRs to bind Prometheus and Grafana to deployed workflows.
I'll break it down into Grafana and Prometheus integration, so we can verify those PRs separately.
Can you create this dashboard and share it with me? So we can maintain and keep it in this repo. Feel free to send a follow up PR to the implemented feature updating the one I'll use as a placeholder. |
@JudeNiroshan one more thing regarding Grafana Data Sources. Please see: https://grafana.github.io/grafana-operator/docs/api/#grafanadatasourcespecdatasource Looks like a data source requires credentials to access Prometheus. We can deploy the DS using the well-known credentials for a simple Prometheus installation, but in production environments, I don't think we can rely on this. In this case, we can accept a secret containing the Prometheus credentials or use the well-known if empty. |
Understood. Let's keep the installation outside the sonataflow operator.(e.g. in a helm chart)
Sure.
Agreed. @ricardozanini Will this feature be considered for the next immediate sonataflow release(13th June 2024)? |
@JudeNiroshan I'm afraid not. Also, we already cut upstream already for the operator. This one should be on Apache KIE 11.x. |
Description
Placeholder EPIC for issues related to adding monitoring support to the SonataFlow Operator.
Relates to:
Issues
ServiceMonitor
object that can capture/collect metrics from deployedSonataFlow
instances #464DataSource
with SonataFlow Prometheus metrics #465The text was updated successfully, but these errors were encountered: