Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1755 - Fix SpellSheck runner and warning in script files #1756

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

ricardozanini
Copy link
Member

In this PR, we fixed the SpellSheck runner (thanks @thiagoelg) and a few warns in our script files.

Closes #1755

Many thanks for submitting your Pull Request ❤️!

Please make sure your PR meets the following requirements:

  • You have read the contributors guide
  • Pull Request title is properly formatted: [Issue XXXX] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a testcase that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster
  • You've added a RELEASE_NOTES.md entry regarding this change
How to retest this PR or trigger a specific build:
  • (Re)run Jenkins tests
    Please add comment: Jenkins [test|retest] this
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Copy link
Member

@thiagoelg thiagoelg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kie-ci3
Copy link
Contributor

kie-ci3 commented Apr 10, 2024

PR job #148 was: UNSTABLE
Possible explanation: This should be test failures

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/148/display/redirect
See console log:

Console Logs [Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1756 - kogito-jit-runner: https://github.com//pull/1756 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1756 - kogito-data-index-ephemeral: https://github.com//pull/1756 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1756 - kogito-jobs-service-ephemeral: https://github.com//pull/1756 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1756 - kogito-jobs-service-allinone: https://github.com//pull/1756 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1756 - kogito-task-console: https://github.com//pull/1756 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1756 - kogito-swf-builder: https://github.com//pull/1756 completed: UNSTABLE
[Pipeline] unstable
WARNING: Tests on kogito-swf-builder seems to have failed
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1756 - kogito-swf-devmode: https://github.com//pull/1756 completed: UNSTABLE
[Pipeline] unstable
WARNING: Tests on kogito-swf-devmode seems to have failed
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // dir
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] sh
+ wget --no-check-certificate -qO - 'https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/148/api/json?depth=0'
[Pipeline] readJSON
[Pipeline] sh

@ricardozanini
Copy link
Member Author

hey @jakubschwan can you please verify so we can unlock @thiagoelg's PR 😄

@ricardozanini ricardozanini merged commit 1e77d9e into apache:main Apr 12, 2024
3 of 4 checks passed
@ricardozanini ricardozanini deleted the issue-1755 branch April 12, 2024 11:17
rgdoliveira pushed a commit to rgdoliveira/incubator-kie-kogito-images that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ShellCheck might not be working in the PR Checks
4 participants