Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE - Fix Service Discovery BDD Test Scenario for SonataFlow devmode and builder. #1718

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

ricardozanini
Copy link
Member

Many thanks for submitting your Pull Request ❤️!

In this PR, we do a small fix in the feature test to verify if the service discovery add-on is installed. In the previous version, when we used Fabric8 the logs were printing a message failing to find the given service. Now that we are defaulting to the operator svc discovery, we don't have this message in the logs anymore, hence the error.

Relates to #1713

CI reported the error here: https://ci-builds.apache.org/blue/organizations/jenkins/KIE%2Fkogito%2Fmain%2Fnightly%2Fkogito-images.build-image/detail/kogito-images.build-image/172/pipeline/

Please make sure your PR meets the following requirements:

  • You have read the contributors guide
  • Pull Request title is properly formatted: [KOGITO|RHPAM-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a testcase that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster
  • You've added a RELEASE_NOTES.md entry regarding this change
How to retest this PR or trigger a specific build:
  • (Re)run Jenkins tests
    Please add comment: Jenkins [test|retest] this

  • Prod tests
    Please add comment: Jenkins (re)run [prod|Prod|PROD]

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@ricardozanini
Copy link
Member Author

@jstastny-cz can you shed light on this CI error?

Index 1 out of bounds for length 1

@jstastny-cz
Copy link
Contributor

I officially hate the github branch source plugin, see:

For PR coming from my fork:
CHANGE_FORK=jstastny-cz/kogito-images

For PR coming from your fork:
CHANGE_FORK=ricardozanini

just because in your case the repository name equals.

That's wonderful for stability :/

@rodrigonull @cimbalek if you ever see this in future ;-) I'll add some ifs in the util scripts now.

@jstastny-cz
Copy link
Contributor

We need

merged before retriggering.

Also I think this would prevent PR checks from working correctly:

And fix for that one would re-generate the pipelines.

@apache apache deleted a comment from kie-ci3 Dec 15, 2023
@kie-ci3
Copy link
Contributor

kie-ci3 commented Dec 15, 2023

PR job #7 was: FAILURE
Possible explanation: Pipeline failure or project build failure

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/7/display/redirect
See console log:

Console Logs [Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] error
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Failed in branch kogito-trusty-ui
[Pipeline] error
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Failed in branch kogito-management-console
[Pipeline] error
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Failed in branch kogito-task-console
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] unstable
WARNING: Tests on kogito-s2i-builder seems to have failed
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // dir
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] sh
+ wget --no-check-certificate -qO - 'https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/7/api/json?depth=0'
[Pipeline] readJSON
[Pipeline] sh

@ricardozanini ricardozanini merged commit 000d4eb into apache:main Dec 22, 2023
3 of 4 checks passed
@ricardozanini ricardozanini deleted the no-issue-fix-bdd branch December 22, 2023 22:11
rgdoliveira pushed a commit to rgdoliveira/incubator-kie-kogito-images that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants