Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kie-issues#628] Change JBoss Nexus to Apache Nexus. #1705

Closed
wants to merge 1 commit into from

Conversation

baldimir
Copy link
Contributor

Changes references to JBoss Nexus to Apache Nexus.

Copy link
Contributor

@jstastny-cz jstastny-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@spolti
Copy link
Member

spolti commented Oct 13, 2023

Does the Apache Nexus have the Quarkus dependencies?

@ricardozanini
Copy link
Member

@baldimir I also share the same concerns if the required libs can be found there. I'm pretty positive that Apache Nexus has a central mirror, so we should be fine.

Regarding the CI:

Could not find credentials entry with ID 'kie-ci1-token'

Do we need to do anything from our side? It seems a config problem.

@jstastny-cz
Copy link
Contributor

Jenkins job failure related to apache/incubator-kie-issues#632 . I'll take that one now, if you can cope without the PR check, feel free to merge as soon as you have necessary reviews

@baldimir
Copy link
Contributor Author

@ricardozanini are these changes fine please? If yes, please approve.

@ricardozanini
Copy link
Member

ricardozanini commented Oct 25, 2023

@baldimir sure, do we know why CI is red?

Seems like a GH API problem:

+ wget --no-check-certificate -qO - GITHUBapi/json?depth=0

@baldimir
Copy link
Contributor Author

As far as I understand (please correct me if wrong @jstastny-cz), the Jenkins PR check for kogito-images needs to be rewritten as it is using an unsupported Jenkins plugin.

@ricardozanini
Copy link
Member

@baldimir how do we check then that this change won't bring bugs to the images?

@baldimir
Copy link
Contributor Author

I see there are some GHA checks, are those working properly? Do you know please?

For the change itself - we cannot release in Apache, if we use JBoss Nexus. So even with broken Jenkins PR check, we need this change.

@ricardozanini
Copy link
Member

@baldimir as discussed, let's try to fix the CI first since it does the integration tests we need to make sure everything is fine with these changes. The GHAs checks are more unit/static verifications. I believe we should assure at least the IT before merging this.

@jstastny-cz
Copy link
Contributor

This all has hopefully become part of

And this one can be closed.

@baldimir baldimir closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants