-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kie-issues#628] Change JBoss Nexus to Apache Nexus. #1705
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Does the Apache Nexus have the Quarkus dependencies? |
@baldimir I also share the same concerns if the required libs can be found there. I'm pretty positive that Apache Nexus has a central mirror, so we should be fine. Regarding the CI:
Do we need to do anything from our side? It seems a config problem. |
Jenkins job failure related to apache/incubator-kie-issues#632 . I'll take that one now, if you can cope without the PR check, feel free to merge as soon as you have necessary reviews |
@ricardozanini are these changes fine please? If yes, please approve. |
@baldimir sure, do we know why CI is red? Seems like a GH API problem:
|
As far as I understand (please correct me if wrong @jstastny-cz), the Jenkins PR check for kogito-images needs to be rewritten as it is using an unsupported Jenkins plugin. |
@baldimir how do we check then that this change won't bring bugs to the images? |
I see there are some GHA checks, are those working properly? Do you know please? For the change itself - we cannot release in Apache, if we use JBoss Nexus. So even with broken Jenkins PR check, we need this change. |
@baldimir as discussed, let's try to fix the CI first since it does the integration tests we need to make sure everything is fine with these changes. The GHAs checks are more unit/static verifications. I believe we should assure at least the IT before merging this. |
This all has hopefully become part of And this one can be closed. |
Changes references to JBoss Nexus to Apache Nexus.