-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KOGITO-9791] build-quarkus-app.sh: properly define versions of org.apache.maven.plugins to avoid downloading old artifacts #1686
Conversation
PR job Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1059/display/redirect Console Logs[Pipeline] }[Pipeline] // stage [Pipeline] } Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-swf-builder: https://github.com/kiegroup/kogito-images/pull/1686 completed: SUCCESS [Pipeline] } [Pipeline] // stage [Pipeline] } Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-swf-devmode: https://github.com/kiegroup/kogito-images/pull/1686 completed: SUCCESS [Pipeline] } [Pipeline] // stage [Pipeline] } Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-s2i-builder: https://github.com/kiegroup/kogito-images/pull/1686 completed: UNSTABLE [Pipeline] unstable WARNING: Tests on kogito-s2i-builder seems to have failed [Pipeline] } [Pipeline] // stage [Pipeline] } [Pipeline] // parallel [Pipeline] } [Pipeline] // script [Pipeline] } [Pipeline] // withEnv [Pipeline] } [Pipeline] // stage [Pipeline] stage [Pipeline] { (Declarative: Post Actions) [Pipeline] script [Pipeline] { [Pipeline] echo [INFO] Clean workspace [Pipeline] cleanWs [WS-CLEANUP] Deleting project workspace... [WS-CLEANUP] Deferred wipeout is used... [WS-CLEANUP] done [Pipeline] echo [INFO] Workspace cleaned [Pipeline] echo [INFO] Cleanup Maven artifacts [Pipeline] sh + rm -rf /home/jenkins/.m2/repository [Pipeline] echo [INFO] .m2/repository cleaned [Pipeline] } [Pipeline] // script [Pipeline] script [Pipeline] { [Pipeline] sh + wget --no-check-certificate -qO - 'https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1059/api/json?depth=0' [Pipeline] readJSON [Pipeline] sh |
Jenkins retest this |
PR job Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1060/display/redirect Console Logs------------------------------------------------------------- [ERROR] Can't merge source into Target. Please rebase PR branch. ------------------------------------------------------------- Source: git://github.com/rgdoliveira/kogito-images inject_jboss-parent Target: 1068c32 [main] Update version to 2.0.0-snapshot ------------------------------------------------------------- [Pipeline] } [Pipeline] // script [Pipeline] } [Pipeline] // withEnv [Pipeline] } [Pipeline] // stage [Pipeline] stage [Pipeline] { (Validate CeKit Image and Modules descriptors) Stage "Validate CeKit Image and Modules descriptors" skipped due to earlier failure(s) [Pipeline] } [Pipeline] // stage [Pipeline] stage [Pipeline] { (Build & Test Images) Stage "Build & Test Images" skipped due to earlier failure(s) [Pipeline] } [Pipeline] // stage [Pipeline] stage [Pipeline] { (Declarative: Post Actions) [Pipeline] script [Pipeline] { [Pipeline] echo [INFO] Clean workspace [Pipeline] cleanWs [WS-CLEANUP] Deleting project workspace... [WS-CLEANUP] Deferred wipeout is used... [WS-CLEANUP] done [Pipeline] echo [INFO] Workspace cleaned [Pipeline] echo [INFO] Cleanup Maven artifacts [Pipeline] sh + rm -rf /home/jenkins/.m2/repository [Pipeline] echo [INFO] .m2/repository cleaned [Pipeline] } [Pipeline] // script [Pipeline] script [Pipeline] { [Pipeline] sh + wget --no-check-certificate -qO - 'https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1060/api/json?depth=0' [Pipeline] readJSON [Pipeline] sh |
@rgdoliveira you need to rebase ;) |
b04c0b5
to
04037ea
Compare
PR job Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1061/display/redirect Console Logs[Pipeline] }[Pipeline] // stage [Pipeline] } Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-management-console: https://github.com/kiegroup/kogito-images/pull/1686 completed: SUCCESS [Pipeline] } [Pipeline] // stage [Pipeline] } Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-swf-devmode: https://github.com/kiegroup/kogito-images/pull/1686 completed: UNSTABLE [Pipeline] unstable WARNING: Tests on kogito-swf-devmode seems to have failed [Pipeline] } [Pipeline] // stage [Pipeline] } Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-s2i-builder: https://github.com/kiegroup/kogito-images/pull/1686 completed: SUCCESS [Pipeline] } [Pipeline] // stage [Pipeline] } [Pipeline] // parallel [Pipeline] } [Pipeline] // script [Pipeline] } [Pipeline] // withEnv [Pipeline] } [Pipeline] // stage [Pipeline] stage [Pipeline] { (Declarative: Post Actions) [Pipeline] script [Pipeline] { [Pipeline] echo [INFO] Clean workspace [Pipeline] cleanWs [WS-CLEANUP] Deleting project workspace... [WS-CLEANUP] Deferred wipeout is used... [WS-CLEANUP] done [Pipeline] echo [INFO] Workspace cleaned [Pipeline] echo [INFO] Cleanup Maven artifacts [Pipeline] sh + rm -rf /home/jenkins/.m2/repository [Pipeline] echo [INFO] .m2/repository cleaned [Pipeline] } [Pipeline] // script [Pipeline] script [Pipeline] { [Pipeline] sh + wget --no-check-certificate -qO - 'https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1061/api/json?depth=0' [Pipeline] readJSON [Pipeline] sh |
hi, can we have a jira for this change? |
have you already reported the jira @ricardozanini or we need to create a now one? |
@mareknovotny @spolti we don't have a JIRA, I think @rgdoliveira identified the issue and pushed the changes based on our conversation. |
@ricardozanini exactly, I created the PR based on our conversation in the channel last week. I didn't create a Jira for it because I was not sure if we would use this approach or not. So in case we agree on doing that, I can create a Jira and attach to this PR. Please, just let me know how we want to proceed. |
@radtriste @rgdoliveira if we can afford to test these changes with the operator, I'm all in. So, I believe we need a JIRA/EPIC to address all the critical CVEs we have in the images. |
@ricardozanini I'm not sure how this changes can be tested with the Operator? I will let @radtriste answer if he knows. Basically the |
We need to build the images based on this PR and run a few tests with the operator using these images. |
@ricardozanini hmm @radtriste can correct me if I'm wrong, but I think on the community side the devmode and builder images are built in a different way than in productization. In community they don't use the |
btw, I did a better check in the generated maven repo and it seems that using the jboss-parent actually doesn't help a lot with some old artifacts included. anyway, I will create a Jira today so we can track this and I will try a different approach to see if I can get better results. I've created Jira https://issues.redhat.com/browse/KOGITO-9791 |
04037ea
to
48cc35e
Compare
PR job Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1063/display/redirect Console Logs[Pipeline] }[Pipeline] // stage [Pipeline] } Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-trusty-ui: https://github.com/kiegroup/kogito-images/pull/1686 completed: SUCCESS [Pipeline] } [Pipeline] // stage [Pipeline] } Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-swf-devmode: https://github.com/kiegroup/kogito-images/pull/1686 completed: UNSTABLE [Pipeline] unstable WARNING: Tests on kogito-swf-devmode seems to have failed [Pipeline] } [Pipeline] // stage [Pipeline] } Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-s2i-builder: https://github.com/kiegroup/kogito-images/pull/1686 completed: SUCCESS [Pipeline] } [Pipeline] // stage [Pipeline] } [Pipeline] // parallel [Pipeline] } [Pipeline] // script [Pipeline] } [Pipeline] // withEnv [Pipeline] } [Pipeline] // stage [Pipeline] stage [Pipeline] { (Declarative: Post Actions) [Pipeline] script [Pipeline] { [Pipeline] echo [INFO] Clean workspace [Pipeline] cleanWs [WS-CLEANUP] Deleting project workspace... [WS-CLEANUP] Deferred wipeout is used... [WS-CLEANUP] done [Pipeline] echo [INFO] Workspace cleaned [Pipeline] echo [INFO] Cleanup Maven artifacts [Pipeline] sh + rm -rf /home/jenkins/.m2/repository [Pipeline] echo [INFO] .m2/repository cleaned [Pipeline] } [Pipeline] // script [Pipeline] script [Pipeline] { [Pipeline] sh + wget --no-check-certificate -qO - 'https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1063/api/json?depth=0' [Pipeline] readJSON [Pipeline] sh |
@ricardozanini @radtriste @desmax74 I've built the devmode and builder images used for OSL 1.30 using a new maven repository.zip that was generated using this PR. The images are available on docker.io and can be pulled with: |
48cc35e
to
6446c44
Compare
PR job Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1064/display/redirect Console Logs[Pipeline] }[Pipeline] // stage [Pipeline] } Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-trusty-ui: https://github.com/kiegroup/kogito-images/pull/1686 completed: SUCCESS [Pipeline] } [Pipeline] // stage [Pipeline] } Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-swf-devmode: https://github.com/kiegroup/kogito-images/pull/1686 completed: UNSTABLE [Pipeline] unstable WARNING: Tests on kogito-swf-devmode seems to have failed [Pipeline] } [Pipeline] // stage [Pipeline] } Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-s2i-builder: https://github.com/kiegroup/kogito-images/pull/1686 completed: SUCCESS [Pipeline] } [Pipeline] // stage [Pipeline] } [Pipeline] // parallel [Pipeline] } [Pipeline] // script [Pipeline] } [Pipeline] // withEnv [Pipeline] } [Pipeline] // stage [Pipeline] stage [Pipeline] { (Declarative: Post Actions) [Pipeline] script [Pipeline] { [Pipeline] echo [INFO] Clean workspace [Pipeline] cleanWs [WS-CLEANUP] Deleting project workspace... [WS-CLEANUP] Deferred wipeout is used... [WS-CLEANUP] done [Pipeline] echo [INFO] Workspace cleaned [Pipeline] echo [INFO] Cleanup Maven artifacts [Pipeline] sh + rm -rf /home/jenkins/.m2/repository [Pipeline] echo [INFO] .m2/repository cleaned [Pipeline] } [Pipeline] // script [Pipeline] script [Pipeline] { [Pipeline] sh + wget --no-check-certificate -qO - 'https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1064/api/json?depth=0' [Pipeline] readJSON [Pipeline] sh |
@radtriste @ricardozanini could you please review? @desmax74 tested the changes with the Operator and it seems fine. |
…pache.maven.plugins to avoid downloading old artifacts
6446c44
to
d5729be
Compare
PR job Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1066/display/redirect Console Logs[Pipeline] error[Pipeline] } [Pipeline] // stage [Pipeline] } Failed in branch kogito-management-console Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-trusty-ui: https://github.com/kiegroup/kogito-images/pull/1686 completed: FAILURE [Pipeline] error [Pipeline] } [Pipeline] // stage [Pipeline] } Failed in branch kogito-trusty-ui Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-task-console: https://github.com/kiegroup/kogito-images/pull/1686 completed: FAILURE [Pipeline] error [Pipeline] } [Pipeline] // stage [Pipeline] } Failed in branch kogito-task-console [Pipeline] // parallel [Pipeline] } [Pipeline] // script [Pipeline] } [Pipeline] // withEnv [Pipeline] } [Pipeline] // stage [Pipeline] stage [Pipeline] { (Declarative: Post Actions) [Pipeline] script [Pipeline] { [Pipeline] echo [INFO] Clean workspace [Pipeline] cleanWs [WS-CLEANUP] Deleting project workspace... [WS-CLEANUP] Deferred wipeout is used... [WS-CLEANUP] done [Pipeline] echo [INFO] Workspace cleaned [Pipeline] echo [INFO] Cleanup Maven artifacts [Pipeline] sh + rm -rf /home/jenkins/.m2/repository [Pipeline] echo [INFO] .m2/repository cleaned [Pipeline] } [Pipeline] // script [Pipeline] script [Pipeline] { [Pipeline] sh + wget --no-check-certificate -qO - 'https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1066/api/json?depth=0' [Pipeline] readJSON [Pipeline] sh |
Jenkins retest this |
8550552
to
ff738b6
Compare
PR job Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1067/display/redirect Console Logs[Pipeline] // stage[Pipeline] } Resuming build at Tue Sep 12 19:15:27 UTC 2023 after Jenkins restart Waiting for reconnection of rhos-d-kie-rhel8-large-osbs-podman-2515 before proceeding with build Timeout set to expire in 25 min Ready to run at Tue Sep 12 19:15:28 UTC 2023 Cancelling nested steps due to timeout Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-runtime-jvm: https://github.com/kiegroup/kogito-images/pull/1686 completed: ABORTED [Pipeline] } [Pipeline] // stage [Pipeline] } Failed in branch kogito-runtime-jvm Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-s2i-builder: https://github.com/kiegroup/kogito-images/pull/1686 completed: ABORTED [Pipeline] } [Pipeline] // stage [Pipeline] } Failed in branch kogito-s2i-builder [Pipeline] // parallel [Pipeline] } [Pipeline] // script [Pipeline] } [Pipeline] // withEnv [Pipeline] } [Pipeline] // stage [Pipeline] stage [Pipeline] { (Declarative: Post Actions) [Pipeline] script [Pipeline] { [Pipeline] echo [INFO] Clean workspace [Pipeline] cleanWs [WS-CLEANUP] Deleting project workspace... [WS-CLEANUP] Deferred wipeout is used... [WS-CLEANUP] done [Pipeline] echo [INFO] Workspace cleaned [Pipeline] echo [INFO] Cleanup Maven artifacts [Pipeline] sh + rm -rf /home/jenkins/.m2/repository [Pipeline] echo [INFO] .m2/repository cleaned [Pipeline] } [Pipeline] // script [Pipeline] script [Pipeline] { [Pipeline] sh + wget --no-check-certificate -qO - 'https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1067/api/json?depth=0' [Pipeline] readJSON [Pipeline] sh |
PR job Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1068/display/redirect Console Logs[Pipeline] // stage[Pipeline] } Resuming build at Tue Sep 12 19:15:28 UTC 2023 after Jenkins restart Waiting for reconnection of rhos-d-kie-rhel8-large-osbs-podman-2529 before proceeding with build Timeout set to expire in 29 min Ready to run at Tue Sep 12 19:15:28 UTC 2023 Cancelling nested steps due to timeout Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-runtime-jvm: https://github.com/kiegroup/kogito-images/pull/1686 completed: ABORTED [Pipeline] } [Pipeline] // stage [Pipeline] } Failed in branch kogito-runtime-jvm Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-s2i-builder: https://github.com/kiegroup/kogito-images/pull/1686 completed: ABORTED [Pipeline] } [Pipeline] // stage [Pipeline] } Failed in branch kogito-s2i-builder [Pipeline] // parallel [Pipeline] } [Pipeline] // script [Pipeline] } [Pipeline] // withEnv [Pipeline] } [Pipeline] // stage [Pipeline] stage [Pipeline] { (Declarative: Post Actions) [Pipeline] script [Pipeline] { [Pipeline] echo [INFO] Clean workspace [Pipeline] cleanWs [WS-CLEANUP] Deleting project workspace... [WS-CLEANUP] Deferred wipeout is used... [WS-CLEANUP] done [Pipeline] echo [INFO] Workspace cleaned [Pipeline] echo [INFO] Cleanup Maven artifacts [Pipeline] sh + rm -rf /home/jenkins/.m2/repository [Pipeline] echo [INFO] .m2/repository cleaned [Pipeline] } [Pipeline] // script [Pipeline] script [Pipeline] { [Pipeline] sh + wget --no-check-certificate -qO - 'https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1068/api/json?depth=0' [Pipeline] readJSON [Pipeline] sh |
Many thanks for submitting your Pull Request ❤️!
Please make sure your PR meets the following requirements:
[KOGITO|RHPAM-XYZ] Subject
How to retest this PR or trigger a specific build:
(Re)run Jenkins tests
Please add comment: Jenkins [test|retest] this
Prod tests
Please add comment: Jenkins (re)run [prod|Prod|PROD]
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.