Setup lts patch

[radtriste]

Following update done on 1.40.x-prod https://github.com/kiegroup/kogito-images/pull/1611

Many thanks for submitting your Pull Request ❤️!

Please make sure your PR meets the following requirements:

• You have read the contributors guide
• Pull Request title is properly formatted: [KOGITO|RHPAM-XYZ] Subject
• Pull Request contains link to the JIRA issue
• Pull Request contains description of the issue
• Pull Request does not include fixes for issues other than the main ticket
• Your feature/bug fix has a testcase that verifies it
• You've tested the new feature/bug fix in an actual OpenShift cluster
• You've added a RELEASE_NOTES.md entry regarding this change

How to retest this PR or trigger a specific build:

• (Re)run Jenkins tests
  Please add comment: Jenkins [test|retest] this

• Prod tests
  Please add comment: Jenkins (re)run [prod|Prod|PROD]

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

[radtriste]

@spolti just thinking whether we should not have directly this change into the module configuration, aka define all extensions with artifact names
This is because some of them are not existing in Quarkus 2.13 platform and we need to define the whole artifact.

[kie-ci1]

PR job #1019 was: FAILURE
Possible explanation: Pipeline failure or project build failure

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1019/display/redirect
See console log:

Console Logs

[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1653 - kogito-management-console: https://github.com/kiegroup/kogito-images/pull/1653 completed: UNSTABLE
[Pipeline] unstable
WARNING: Tests on kogito-management-console seems to have failed
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1653 - kogito-task-console: https://github.com/kiegroup/kogito-images/pull/1653 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1653 - kogito-s2i-builder: https://github.com/kiegroup/kogito-images/pull/1653 completed: UNSTABLE
[Pipeline] unstable
WARNING: Tests on kogito-s2i-builder seems to have failed
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] echo
[INFO] Clean workspace
[Pipeline] cleanWs
[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
[WS-CLEANUP] done
[Pipeline] echo
[INFO] Workspace cleaned
[Pipeline] echo
[INFO] Cleanup Maven artifacts
[Pipeline] sh
+ rm -rf /home/jenkins/.m2/repository
[Pipeline] echo
[INFO] .m2/repository cleaned
[Pipeline] }
[Pipeline] // script
[Pipeline] script
[Pipeline] {
[Pipeline] sh
+ wget --no-check-certificate -qO - https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1019/api/json
[Pipeline] readJSON
[Pipeline] sh

[radtriste]

jenkins retest this

[lampajr]

Hey @radtriste the patch itself looks good to me but I fear it could be hard to maintain in this way, I mean everytime we change QUARKUS_EXTENSIONS here modules/kogito-swf/devmode/build-config/module.yaml we should always update the patch.

So why don't we fully specify all extensions? i.e., <group-id>:<artifact-id>:${KOGITO_VERSION}, is there any issue using this approach on community? if this works it will completely remove the need of having the patch

[radtriste]

Hey @radtriste the patch itself looks good to me but I fear it could be hard to maintain in this way, I mean everytime we change QUARKUS_EXTENSIONS here modules/kogito-swf/devmode/build-config/module.yaml we should always update the patch.

So why don't we fully specify all extensions? i.e., <group-id>:<artifact-id>:${KOGITO_VERSION}, is there any issue using this approach on community? if this works it will completely remove the need of having the patch

This is exactly what I propose to Filippe here: https://github.com/kiegroup/kogito-images/pull/1653#discussion_r1276200853 :)

[lampajr]

This is exactly what I propose to Filippe here: #1653 (comment) :)

Ouch sorry, I completely missed you comment!!
Then, I definitely agree on your proposal :)

[spolti]

@lampajr hi, does this PR still valid?

[lampajr]

@lampajr hi, does this PR still valid?

Hey @spolti , I think it depends on what you think about #1653 (comment). Because if you agree to fully specify all extensions in terms of <group-id>:<artifact-id>:${KOGITO_VERSION} I think we do NOT need this patch (therefore the PR can be closed) but we will need to create different PR to fully specify all extensions there.

[spolti]

@lampajr yeah, I agree with that, the full GAV is better than a patch.
feel free to merge :)

Is the CI working for the kogito-images already?

[lampajr]

@lampajr yeah, I agree with that, the full GAV is better than a patch. feel free to merge :)

Ok so we should create a different PR specifying the full GAV for all extensions and then we can close this one as no patch will be needed at that point.

Is the CI working for the kogito-images already?

TBH I do not know IIRC the issue was just when using Quarkus LTS

[jstastny-cz]

Closing as outdated