[incubator-kie-drools-6161] Review drools-distribution #6201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkobayas
commented
Dec 17, 2024
Comment on lines
+34
to
+43
| <file> | ||
| <source>license-for-distribution</source> | ||
| <outputDirectory>/</outputDirectory> | ||
| <destName>LICENSE</destName> | ||
| </file> | ||
| <file> | ||
| <source>notice-for-distribution</source> | ||
| <outputDirectory>/</outputDirectory> | ||
| <destName>NOTICE</destName> | ||
| </file> |
There was a problem hiding this comment.
Added plain LICENSE and NOTICE. We don't need third-party license entries, because the distribution zip contains only example source codes.
tkobayas
commented
Dec 17, 2024
Comment on lines
-136
to
-149
| <dependencySet> | ||
| <includes> | ||
| <include>org.kie:*:jar:sources</include> | ||
| <include>org.drools:*:jar:sources</include> | ||
| </includes> | ||
| <excludes> | ||
| <exclude>org.drools:drools-examples:jar:sources</exclude> | ||
| </excludes> | ||
| <outputDirectory>sources</outputDirectory> | ||
| <unpack>false</unpack> | ||
| <useStrictFiltering>true</useStrictFiltering> | ||
| <useTransitiveFiltering>true</useTransitiveFiltering> | ||
| <useProjectArtifact>false</useProjectArtifact> | ||
| </dependencySet> |
There was a problem hiding this comment.
Removed source jars to avoid license review.
Users can download source distribution releases via Apache KIE website and more commonly, clone the repository via github.
tkobayas
commented
Dec 17, 2024
Comment on lines
-21
to
-27
| Third party jars | ||
| ---------------- | ||
|
|
||
| Following third party jars are optional and are not included in Drools distribution: | ||
|
|
||
| 1.Quartz: Quartz is an optional jar only needed if you wish to adapt existing quartz calendars. It can be | ||
| downloaded from http://www.quartz-scheduler.org/. |
There was a problem hiding this comment.
Quartz is no longer used.
- Fix ReadMe and assembly
tkobayas
force-pushed
the
incubator-kie-drools-6161-distribution
branch
from
5c1a060 to
40cda66
Compare
mariofusco
approved these changes
Dec 17, 2024
lucamolteni
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
This PR only deals with ReadMe, assembly, LICENSE and NOTICE.
We will then