[KIE-DROOLS-6190] fix removal of detached tuples during incremental compilation #6192
Conversation
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #6192 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6192/1/display/redirect Test results:
Those are the test failures: org.drools.mvel.integrationtests.Misc2Test.testDynamicAddRule(KieBaseTestConfiguration)[1]Expecting value to be true but was false |
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #6192 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6192/2/display/redirect Test results:
Those are the test failures: org.drools.mvel.integrationtests.Misc2Test.testDynamicAddRule(KieBaseTestConfiguration)[1]Expecting value to be true but was false |
|
Test failure on Other test failures in kogito-* are mostly "pull access denied for vectorized/redpanda", which is being investigated by apache/incubator-kie-issues#1682 |
It's good that we had that test, it gave me a better insight of what @mdproctor was attempting to do there and where the problem actually was. This should be fixed now. |
|
@pibizza With the additional fix that I pushed yesterday evening all incremental tests pass, so I re-enabled them all. |
…ompilation (apache#6192) * [KIE-DROOLS-6190] fix removal of detached tuples during incremental compilation * add missing license * wip * wip * wip
Fixes #6190
There are a few other incremental compilation tests that are failing for a totally unrelated reason and anyway without causing any endless loop. I left them disabled and I will keep investigating and fix them with a subsequent pull request.