Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-drools-6136] Migrate drools tests to JUnit5 - #8 #6179

Merged
merged 12 commits into from
Dec 4, 2024

Conversation

pibizza
Copy link
Contributor

@pibizza pibizza commented Dec 3, 2024

New patch to migrate:
-- drools-ecj

  • drools-persistence
  • drools-retediagram
  • drools-serialization-protobuf
  • drools-traits
  • drools-util
  • drools-xml-support
  • kie-api
  • kie-internal
  • kie-memory-compiler

We are down to 58 test files to migrate

Issue: #6136

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request and downstream checks

    • Push a new commit to the PR. An empty commit would be enough.
  • for a full downstream build

    • for github actions job: add the label run_fdb
  • for Jenkins PR check only

@pibizza pibizza requested a review from mariofusco December 3, 2024 15:38
@mariofusco mariofusco requested a review from tkobayas December 3, 2024 17:04
@mariofusco mariofusco merged commit 1316a53 into apache:main Dec 4, 2024
10 checks passed
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Dec 9, 2024
…apache#6179)

* More tests migrated

* Migrated tests to Junit5

* Migrated serialization protobuf module

* Migrated drools-ecj

* Migrated drools persistance

* Migrated drool traits tests

* Migrated drools util module to Junit5

* Migrated drools xml support module to JUnit5

* Migrated kie internals to JUnit5

* Migrated kie memory compiler to JUnit5

* Migrated drools retediagram to JUnit5

* Migrated kie api to JUnit5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants