[incubator-kie-drools-6158] Remove remaining binaries from test resou… #6171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkobayas
commented
Nov 25, 2024
| @@ -128,7 +128,7 @@ private static URL getResourceUrl() { | |||
|
|
|||
| private static URL getJarUrl() throws MalformedURLException { | |||
| URL retrieved = Thread.currentThread().getContextClassLoader().getResource("TestJar.jar"); | |||
| assertThat(retrieved).isNotNull(); | |||
| assertThat(retrieved).as("Run `mvn test` to build TestJar.jar").isNotNull(); | |||
There was a problem hiding this comment.
TestJar.jar creation is done at process-test-resources phase, so TestJar.jar usually exists before running tests. One exception is running tests via IDE before running mvn. For the case, I added this message.
…rces on main - Create TestJar.jar on the fly
tkobayas
force-pushed
the
incubator-kie-drools-6158-TestJar
branch
from
fb1f235 to
eec4be7
Compare
mariofusco
approved these changes
Nov 25, 2024
pibizza
approved these changes
Nov 25, 2024
gitgabrio
approved these changes
Nov 25, 2024
rgdoliveira
added a commit
to rgdoliveira/drools
that referenced
this pull request
Dec 2, 2024
…rces on main (apache#6171) - Create TestJar.jar on the fly # Conflicts: # .rat-excludes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rces on main
Issue: