Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support generic range type in DMN engine #6123

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

baldimir
Copy link
Contributor

@baldimir baldimir requested review from gitgabrio and yesamer October 11, 2024 13:54
Copy link
Contributor

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yesamer
Copy link
Contributor

yesamer commented Oct 14, 2024

@baldimir
Most likely there's a regression, can you please double-check?
I run your changes against the TCK tests and I discovered those failing tests:

Screenshot 2024-10-14 at 10 09 18 Screenshot 2024-10-14 at 10 09 08

IIRC these tests were ok last time I checked.

@yesamer yesamer self-requested a review October 14, 2024 08:12
@baldimir
Copy link
Contributor Author

Those failures are also failing on current main. I will focus on those next.

@yesamer yesamer added the DMN label Oct 14, 2024
Copy link
Contributor

@gitgabrio gitgabrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @baldimir LGTM!

@baldimir
Copy link
Contributor Author

kogito-runtimes and serverless-workflow-examples downstream jobs failed because of Python environment problems, not related to this PR.

@baldimir baldimir merged commit 9711a14 into apache:main Oct 14, 2024
6 of 9 checks passed
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DMN engine doesn't support generic range type
3 participants