[incubator-kie-drools-5974] Possible deadlock with KieRepositoryImpl$… #6006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…KieModuleRepo and KieRepositoryScannerImpl
|
I fixed 7.x with a smaller change (lock order) kiegroup#56 But for main, I introduced ReentrantLock which is more explicit. |
tkobayas
commented
Jun 28, 2024
Comment on lines
+143
to
+151
| // share the lock between KieModuleRepo and KieRepository | ||
| final Field KieModuleRepoLockField = KieModuleRepo.class.getDeclaredField("lock"); | ||
| KieModuleRepoLockField.setAccessible(true); | ||
| Object lock = KieModuleRepoLockField.get(kieModuleRepo); | ||
| KieModuleRepoLockField.setAccessible(false); | ||
| final Field kieRepositoryImplLockField = KieRepositoryImpl.class.getDeclaredField("lock"); | ||
| kieRepositoryImplLockField.setAccessible(true); | ||
| kieRepositoryImplLockField.set(kieRepository, lock); | ||
| kieRepositoryImplLockField.setAccessible(false); |
There was a problem hiding this comment.
This reflection is a little ugly, but reflection was already used in this test, so I followed the approach rather than introducing public accessor for lock.
|
@mariofusco @lucamolteni Please review, thanks! |
lucamolteni
approved these changes
Jul 1, 2024
mariofusco
approved these changes
Jul 8, 2024
rgdoliveira
pushed a commit
to rgdoliveira/drools
that referenced
this pull request
Jul 8, 2024
…KieModuleRepo and KieRepositoryScannerImpl (apache#6006)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…KieModuleRepo and KieRepositoryScannerImpl
Issue: