Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-drools-5841] Improve matches operator performance #283

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

tkobayas
Copy link
Contributor

  • Benchmark

With apache/incubator-kie-drools#5837

Local results:

Benchmark              (_factsNumber)  (_rulesNumber)  (cacheEnabled)  Mode  Cnt  Score   Error  Units
MatchesBenchmark.test              32              16            true    ss   20  2.389 ± 0.278  ms/op
MatchesBenchmark.test              32              16           false    ss   20  2.157 ± 0.439  ms/op
MatchesBenchmark.test              32              32            true    ss   20  2.627 ± 0.517  ms/op
MatchesBenchmark.test              32              32           false    ss   20  3.466 ± 0.822  ms/op
MatchesBenchmark.test             256              16            true    ss   20  2.650 ± 0.521  ms/op
MatchesBenchmark.test             256              16           false    ss   20  4.716 ± 2.079  ms/op
MatchesBenchmark.test             256              32            true    ss   20  4.852 ± 0.945  ms/op
MatchesBenchmark.test             256              32           false    ss   20  7.036 ± 1.410  ms/op

Notable improvement with cacheEnabled=true especially with many facts.

@tkobayas
Copy link
Contributor Author

Btw, we don't need GHA Java 11 because drools main is Java 17. I'll file a PR to remove it.

@baldimir baldimir merged commit bc08f89 into apache:main Apr 16, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants