Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DROOLS-7543 : benchmark to test session restore after failover #266

Merged
merged 2 commits into from
Oct 13, 2023
Merged

DROOLS-7543 : benchmark to test session restore after failover #266

merged 2 commits into from
Oct 13, 2023

Conversation

nprentza
Copy link
Contributor

@tkobayas
Copy link
Contributor

tkobayas commented Oct 11, 2023 •
edited
Loading

@nprentza Could you please confirm if the latest main + this PR can compile? I got

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project drools-benchmarks: Compilation failure
[ERROR] /home/tkobayas/usr/work/DROOLS-7543-Nicole/kie-benchmarks/drools-benchmarks-parent/drools-benchmarks/src/main/java/org/drools/benchmarks/turtle/runtime/AbstractSimpleFusionRuntimeBenchmark.java:[63,5] method does not override or implement a method from a supertype

I believe it was caused by a previous commit (#263), but you can fix it in this PR by removing the unnecessary @Override.

tkobayas
tkobayas reviewed Oct 11, 2023
View reviewed changes
...reliability/src/main/java/org/drools/benchmarks/reliability/InsertFailoverFireBenchmark.java Outdated
@Benchmark
public long test() {
kieSession = restoreSession();
System.out.println("restored : facts size = " + kieSession.getFactHandles().size());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please comment out this line (useful while developing though), because this part is measured.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkobayas thanks, I will comment out the line.

@nprentza
Copy link
Contributor Author

@nprentza Could you please confirm if the latest main + this PR can compile? I got

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project drools-benchmarks: Compilation failure
[ERROR] /home/tkobayas/usr/work/DROOLS-7543-Nicole/kie-benchmarks/drools-benchmarks-parent/drools-benchmarks/src/main/java/org/drools/benchmarks/turtle/runtime/AbstractSimpleFusionRuntimeBenchmark.java:[63,5] method does not override or implement a method from a supertype

I believe it was caused by a previous commit (#263), but you can fix it in this PR by removing the unnecessary @Override.

@tkobayas I fixed this error locally but didn't include it to the PR. I will commit and include the fix to the PR.

tkobayas
tkobayas approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@tkobayas tkobayas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@mariofusco mariofusco merged commit cc89965 into apache:main Oct 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkobayas tkobayas tkobayas approved these changes

@mariofusco mariofusco mariofusco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nprentza @tkobayas @mariofusco