Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(api): ListValue.getFirst() replaces ListValue.get(0) #282

Merged
merged 1 commit into from
Nov 13, 2023
Merged

refactor(api): ListValue.getFirst() replaces ListValue.get(0) #282

merged 1 commit into from
Nov 13, 2023

Conversation

diaohancai
Copy link
Contributor

Purpose of the PR

Main Changes

ListValue.getFirst() replaces ListValue.get(0).

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows.
    Unit test: org.apache.hugegraph.computer.core.graph.value.ListValueTest#testGetFirst

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

imbajin
imbajin approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could also clean the code refer this doc

@diaohancai
Copy link
Contributor Author

diaohancai commented Nov 13, 2023 •
edited
Loading

Thanks, could also clean the code refer this doc

Ok~ I'm debating whether to format the code or not. hh

javeme
javeme approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@javeme javeme left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javeme javeme merged commit 0c447be into apache:master Nov 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imbajin imbajin imbajin approved these changes

@javeme javeme javeme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Refactor] ListValue.get(0) optimization
3 participants
@diaohancai @javeme @imbajin