fix(algorithm): record loop is not copied #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
============================================
- Coverage 85.10% 85.09% -0.02%
- Complexity 3245 3246 +1
============================================
Files 345 345
Lines 12283 12283
Branches 1101 1101
============================================
- Hits 10454 10452 -2
- Misses 1303 1304 +1
- Partials 526 527 +1
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
javeme
reviewed
Oct 25, 2023
| @@ -124,6 +125,10 @@ private void assertResult(Id id, List<String> rings) { | |||
| Set<String> expect = EXPECT_RINGS.getOrDefault(id.toString(), | |||
| new HashSet<>()); | |||
|
|
|||
| rings = rings.stream() | |||
| .distinct() | |||
| .collect(Collectors.toList()); | |||
There was a problem hiding this comment.
seems don't need to distinct since the rings is a Set
There was a problem hiding this comment.
seems don't need to distinct since the rings is a Set
rings is a List.
private void assertResult(Id id, List<String> rings) {
...
}Before fix this bug, it is also a problem that our test can pass.
javeme
approved these changes
Oct 28, 2023
| @@ -124,6 +125,10 @@ private void assertResult(Id id, List<String> rings) { | |||
| Set<String> expect = EXPECT_RINGS.getOrDefault(id.toString(), | |||
| new HashSet<>()); | |||
|
|
|||
| rings = rings.stream() | |||
| .distinct() | |||
| .collect(Collectors.toList()); | |||
imbajin
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Main Changes
The result is not copied when the loop is detected.
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need