Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spark): Support local filesystem in spark library for graphar-info temporarily #561

Closed
wants to merge 2 commits into from

Conversation

jasinliu
Copy link
Contributor

Reason for this PR

fix #554

What changes are included in this PR?

as title.

@acezen acezen self-requested a review July 30, 2024 03:15
@jasinliu
Copy link
Contributor Author

This PR brings a very big change in the usage. When using spark parameter in info, users must add Some to support this Option.

@jasinliu
Copy link
Contributor Author

jasinliu commented Jul 30, 2024

This PR brings a very big change in the usage. When using spark parameter in info, users must add Some to support this Option.

I want to know how to avoid changing the user mode? Another way I can think of is to overload.

@jasinliu
Copy link
Contributor Author

This PR brings a very big change in the usage. When using spark parameter in info, users must add Some to support this Option.

Before the info module arrives, if this PR makes sense, I can try to modify and add some tests.

Copy link
Member

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GraphAr PySpark is broken by these changes.

@jasinliu jasinliu closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(spark): Support local filesystem without sparksession
2 participants