[GLUTEN-8025][VL] set default kSpillWriteBufferSize to the same as velox #8026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
zhouyuan
changed the title
|
Shall we update the code for consistency? Thanks! |
|
Please update the PR to respect |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
close. merge to #8045 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kSpillWriteBufferSize is set to 4M by typo. correct it to 1M. The value control the buffer size when spill write data to disk.
Add config kSpillReadBufferSize. it controls the read buffer size when spill data is fetch back. The memory will be allocated as offheap memory. So if there are to many spill files, the memory will exceed offheap size and trigger the OOM issue by operator::getOutput.
The spill files number is impacted by MaxSpillFileSize and MaxSpillRunRows, both are the smaller the more spill files.