Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CH] Fix memory config spill_mem_ratio always zero #6743

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

liuneng1994
Copy link
Contributor

What changes were proposed in this pull request?

fix memory config spill_mem_ratio always zero

How was this patch tested?

unit tests

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Copy link

github-actions bot commented Aug 7, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

github-actions bot commented Aug 7, 2024

Run Gluten Clickhouse CI

@liuneng1994
Copy link
Contributor Author

image

Copy link
Contributor

@baibaichen baibaichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzcclp zzcclp merged commit a17f544 into apache:main Aug 7, 2024
8 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====

query log/native_master_08_07_2024_time.csv log/native_master_08_05_2024_d6904149f2_time.csv difference percentage
q1 14.17 14.23 0.054 100.38%
q2 13.93 11.94 -1.988 85.73%
q3 2.79 4.68 1.892 167.91%
q4 70.38 69.68 -0.702 99.00%
q5 9.18 9.54 0.368 104.02%
q6 2.11 4.05 1.943 192.06%
q7 6.48 4.99 -1.485 77.08%
q8 3.29 4.97 1.687 151.31%
q9 24.02 24.08 0.067 100.28%
q10 9.31 10.26 0.950 110.21%
q11 36.38 36.98 0.600 101.65%
q12 1.41 1.51 0.094 106.63%
q13 6.29 6.40 0.102 101.63%
q14a 46.84 45.18 -1.653 96.47%
q14b 44.13 42.83 -1.304 97.05%
q15 2.66 2.61 -0.057 97.85%
q16 44.91 45.03 0.122 100.27%
q17 4.93 5.20 0.274 105.57%
q18 6.70 6.69 -0.009 99.86%
q19 2.10 2.18 0.079 103.75%
q20 1.48 1.44 -0.044 97.04%
q21 1.06 1.11 0.053 105.03%
q22 8.76 8.67 -0.086 99.02%
q23a 104.48 101.74 -2.737 97.38%
q23b 125.04 126.30 1.260 101.01%
q24a 92.98 96.97 3.990 104.29%
q24b 91.37 100.21 8.835 109.67%
q25 4.26 4.16 -0.098 97.69%
q26 3.52 3.41 -0.109 96.89%
q27 5.66 3.99 -1.663 70.60%
q28 30.39 31.90 1.512 104.97%
q29 9.10 10.98 1.887 120.74%
q30 4.65 4.76 0.115 102.47%
q31 6.84 7.14 0.297 104.34%
q32 1.20 1.35 0.152 112.65%
q33 4.20 4.60 0.400 109.52%
q34 4.09 3.90 -0.191 95.34%
q35 7.43 8.95 1.516 120.39%
q36 4.56 4.68 0.123 102.71%
q37 4.50 4.38 -0.117 97.41%
q38 13.15 14.87 1.715 113.04%
q39a 3.49 3.33 -0.159 95.45%
q39b 2.98 3.30 0.322 110.81%
q40 4.00 3.92 -0.079 98.02%
q41 0.61 0.64 0.026 104.29%
q42 0.89 0.90 0.008 100.93%
q43 4.29 4.58 0.289 106.73%
q44 9.27 10.10 0.832 108.98%
q45 3.11 3.20 0.090 102.89%
q46 3.84 3.73 -0.105 97.27%
q47 17.40 17.44 0.041 100.23%
q48 5.08 5.23 0.147 102.89%
q49 8.73 8.83 0.109 101.25%
q50 21.62 21.72 0.093 100.43%
q51 9.95 10.05 0.096 100.97%
q52 1.06 1.06 -0.006 99.43%
q53 2.36 2.45 0.096 104.09%
q54 3.83 3.96 0.123 103.20%
q55 1.08 1.05 -0.030 97.24%
q56 4.15 4.09 -0.055 98.69%
q57 10.53 10.75 0.216 102.05%
q58 2.41 2.47 0.063 102.63%
q59 10.86 10.53 -0.329 96.97%
q60 5.51 4.08 -1.428 74.07%
q61 4.08 4.06 -0.026 99.35%
q62 4.52 4.53 0.009 100.21%
q63 2.47 2.31 -0.161 93.48%
q64 59.18 63.72 4.537 107.67%
q65 17.04 17.57 0.526 103.08%
q66 3.85 3.84 -0.010 99.75%
q67 391.46 383.79 -7.675 98.04%
q68 3.53 3.63 0.094 102.65%
q69 5.26 5.14 -0.119 97.74%
q70 11.41 11.57 0.163 101.42%
q71 2.63 2.41 -0.229 91.30%
q72 214.47 217.49 3.019 101.41%
q73 2.53 2.36 -0.162 93.58%
q74 22.88 23.12 0.243 101.06%
q75 26.12 26.76 0.632 102.42%
q76 12.48 11.42 -1.060 91.51%
q77 2.36 2.24 -0.121 94.88%
q78 49.79 49.63 -0.158 99.68%
q79 3.85 4.06 0.207 105.37%
q80 12.20 12.15 -0.048 99.60%
q81 4.72 4.70 -0.018 99.62%
q82 6.74 6.65 -0.083 98.77%
q83 1.68 1.60 -0.078 95.33%
q84 2.63 2.69 0.060 102.28%
q85 7.27 6.88 -0.391 94.62%
q86 3.97 3.90 -0.068 98.30%
q87 13.93 13.07 -0.859 93.83%
q88 21.26 21.17 -0.091 99.57%
q89 3.51 3.51 0.005 100.14%
q90 3.02 3.26 0.244 108.09%
q91 2.15 2.04 -0.114 94.72%
q92 1.28 1.29 0.017 101.36%
q93 40.89 38.69 -2.196 94.63%
q94 24.89 24.93 0.046 100.18%
q9 89.61 90.54 0.929 101.04%
q5 2.52 2.40 -0.111 95.57%
q96 17.54 17.42 -0.120 99.31%
q97 1.96 1.92 -0.044 97.77%
q98 9.50 10.02 0.517 105.44%
q99 9.50 10.02 0.517 105.44%
total 2128.96 2144.47 15.511 100.73%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_08_07_2024_time.csv log/native_master_08_06_2024_43d0ff987_time.csv difference percentage
q1 39.51 39.33 -0.185 99.53%
q2 29.71 30.04 0.328 101.10%
q3 51.23 52.80 1.563 103.05%
q4 42.00 42.85 0.849 102.02%
q5 102.50 103.73 1.231 101.20%
q6 10.91 12.92 2.009 118.42%
q7 115.50 115.21 -0.293 99.75%
q8 113.37 115.81 2.435 102.15%
q9 169.04 170.54 1.503 100.89%
q10 66.53 65.15 -1.381 97.92%
q11 26.66 30.39 3.736 114.02%
q12 29.99 29.54 -0.454 98.49%
q13 51.34 51.99 0.650 101.27%
q14 23.56 24.57 1.013 104.30%
q15 53.79 54.96 1.171 102.18%
q16 18.80 18.91 0.113 100.60%
q17 132.03 131.69 -0.335 99.75%
q18 199.36 197.72 -1.644 99.18%
q19 26.50 25.65 -0.850 96.79%
q20 41.84 40.93 -0.912 97.82%
q21 367.17 381.33 14.159 103.86%
q22 15.57 15.48 -0.086 99.45%
total 1726.91 1751.53 24.620 101.43%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants