-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Fall back scan if file scheme is not supported by registered file systems #6672
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
cc @PHILO-HE , thanks. |
@wForget, could you take a look if you have time? |
@zhli1142015 Thanks for your work, as comment in #4086 (comment) suggested putting the validation into |
Yes. There are lots of change sinse your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhli1142015, just posted some comments. Thanks!
backends-velox/src/test/scala/org/apache/gluten/execution/FallbackSuite.scala
Outdated
Show resolved
Hide resolved
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala
Outdated
Show resolved
Hide resolved
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
gluten-core/src/main/scala/org/apache/gluten/utils/FileIndexUtil.scala
Outdated
Show resolved
Hide resolved
shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala
Outdated
Show resolved
Hide resolved
shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala
Outdated
Show resolved
Hide resolved
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala
Show resolved
Hide resolved
backends-velox/src/test/scala/org/apache/gluten/execution/FallbackSuite.scala
Outdated
Show resolved
Hide resolved
gluten-core/src/main/scala/org/apache/gluten/execution/FileSourceScanExecTransformer.scala
Outdated
Show resolved
Hide resolved
gluten-core/src/main/scala/org/apache/gluten/utils/FileIndexUtil.scala
Outdated
Show resolved
Hide resolved
shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala
Outdated
Show resolved
Hide resolved
backends-velox/src/test/scala/org/apache/gluten/execution/FallbackSuite.scala
Outdated
Show resolved
Hide resolved
gluten-core/src/main/scala/org/apache/gluten/execution/BasicScanExecTransformer.scala
Outdated
Show resolved
Hide resolved
Run Gluten Clickhouse CI |
gluten-core/src/main/scala/org/apache/spark/sql/hive/HiveTableScanExecTransformer.scala
Show resolved
Hide resolved
gluten-iceberg/src/main/scala/org/apache/gluten/execution/IcebergScanTransformer.scala
Show resolved
Hide resolved
Thanks, overall LGTM. |
@zhli1142015, could you respond to @wForget's comments? |
Run Gluten Clickhouse CI |
Just updated, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
What changes were proposed in this pull request?
Fallback scan if root path is not supported by registered file systems
Fixes: #6620
How was this patch tested?
UT.