Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled replicaCount #269

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+12 −7
Open

Enabled replicaCount #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e221a9c
Enabled replicaCount
Apr 1, 2024
47b06b7
pullrequestreview-1972726168
Apr 9, 2024
84dd8a9
Merge branch 'main' into enabled-replicaCount
angelsanchezdck Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion HelmSetup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,11 @@ Some useful parameters for the chart, you could also check them in values.yaml

| Parameter | Description | Default |
| -------------------------------------- | ------------------------------------------------------------------------------------- | ------------------------ |
| replicaCount | Replica Count for devlake, currently not used | 1 |
| replicaCount | Replica Count for devlake, currently not used (removed) | 1 |
| imageTag | The version tag for all images | see Values.yaml |
| imagePullSecrets | Name of the Secret for accessing private image registries | [] |
| commonEnvs | The common envs for all pods except grafana | {TZ: "UTC"} |
| mysql.replicaCount | Replica count can only be 0 or 1 | 1 |
| mysql.useExternal | If use external mysql server, set true | false |
| mysql.externalServer | External mysql server address | 127.0.0.1 |
| mysql.externalPort | External mysql server port | 3306 |
Expand All @@ -169,6 +170,7 @@ Some useful parameters for the chart, you could also check them in values.yaml
| mysql.service.type | mysql service type | ClusterIP |
| mysql.service.nodePort | specify mysql nodeport | "" |
| grafana | dashboard, datasource, etc. settings for grafana, installed by grafana official chart | |
| lake.replicaCount | Replica count can only be 0 or 1 | 1 |
| lake.image.repository | repository for lake's image | apache/devlake |
| lake.image.pullPolicy | pullPolicy for lake's image | Always |
| lake.port | the port of devlake backend | 8080 |
Expand All @@ -184,6 +186,7 @@ Some useful parameters for the chart, you could also check them in values.yaml
| lake.livenessProbe | container livenessprobe | see Values.yaml |
| lake.readinessProbe | container readinessProbe | see Values.yaml |
| lake.deployment.extraLabels | extra labels for lake's deployment metadata | {} |
| ui.replicaCount | Replica count for ui | 1 |
| ui.image.repository | repository for ui's image | apache/devlake-config-ui |
| ui.image.pullPolicy | pullPolicy for ui's image | Always |
| ui.basicAuth.enabled | If the basic auth in ui is enabled | false |
Expand Down
4 changes: 2 additions & 2 deletions charts/devlake/templates/deployments.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ metadata:
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
replicas: 1
replicas: {{ .Values.ui.replicaCount }}
{{- with .Values.ui.strategy }}
strategy:
{{- toYaml . | nindent 4 }}
Expand Down Expand Up @@ -129,7 +129,7 @@ metadata:
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
replicas: 1
replicas: {{ if gt .Values.lake.replicaCount 1 }}1{{ else }}{{ .Values.lake.replicaCount }}{{ end }}
{{- with .Values.lake.strategy }}
strategy:
{{- toYaml . | nindent 4 }}
Expand Down
2 changes: 1 addition & 1 deletion charts/devlake/templates/statefulsets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ metadata:
labels:
{{- include "devlake.labels" . | nindent 4 }}
spec:
replicas: 1
replicas: {{ if gt .Values.mysql.replicaCount 1 }}1{{ else }}{{ .Values.mysql.replicaCount }}{{ end }}
serviceName: {{ include "devlake.fullname" . }}-mysql
selector:
matchLabels:
Expand Down
8 changes: 5 additions & 3 deletions charts/devlake/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@
# limitations under the License.
#

# replica count
replicaCount: 1
imageTag: v1.0.1
imageTag: v1.0.0-beta3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the imageTag should not be changed, keep the same as main branch



# image pull secrets
imagePullSecrets: []
Expand All @@ -27,6 +26,7 @@ commonEnvs:
TZ: "UTC"

mysql:
replicaCount: 1
# if use external mysql server, please set true
# by default using false, chart will create a single mysql instance
useExternal: false
Expand Down Expand Up @@ -171,6 +171,7 @@ grafana:
ingressServicePort: ""

lake:
replicaCount: 1
image:
repository: devlake.docker.scarf.sh/apache/devlake
pullPolicy: Always
Expand Down Expand Up @@ -253,6 +254,7 @@ lake:
extraLabels: {}

ui:
replicaCount: 1
image:
repository: devlake.docker.scarf.sh/apache/devlake-config-ui
pullPolicy: Always
Expand Down
Loading