-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix list namespace response in rest catalog #995
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ndrluis - thank you for the fix. This behavior looks correct to me as well.
We must have misinterpreted the expected behavior from the REST Catalog Open API YAML in the initial implementation.
https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml#L209-L215
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there another way to test this behavior? test_rest.py
is using mocks. Perhaps there's a way to write an integration test comparing to spark
I'll create an issue to set up an integration test suite against our current setup (using the Tabular REST catalog image). However, I think we should add to our roadmap creating a more robust structure. I'm not sure the Tabular REST catalog image will be maintained, and it would be good to test against other catalog implementations. We'll need a simple way to disable some tests in some cases, as tests might fail due to catalog bugs, and we would rather not be blocked by that. |
Issue created #1010 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @ndrluis, thanks for fixing this!
Thanks @ndrluis! |
While testing PyIceberg with Polaris and multi-level namespacing, I noticed a behavior that doesn't align with the REST catalog specification. The expected response should be the fully qualified namespace.