[WIP] Feat: replace sort order #1500
Open
+248
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
kevinjqliu
reviewed
Jan 11, 2025
| @@ -404,6 +405,20 @@ def update_schema(self, allow_incompatible_changes: bool = False, case_sensitive | |||
| name_mapping=self.table_metadata.name_mapping(), | |||
| ) | |||
|
|
|||
| def replace_sort_order(self, case_sensitive: bool = True) -> ReplaceSortOrder: | |||
There was a problem hiding this comment.
nit: wdyt about update_sort_order instead?
from the spec,
A data or delete file is associated with a sort order by the sort order's id within [a manifest](https://iceberg.apache.org/spec/#manifests). Therefore, the table must declare all the sort orders for lookup. A table could also be configured with a default sort order id, indicating how the new data should be sorted by default. Writers should use this default sort order to sort the data on write, but are not required to if the default order is prohibitively expensive, as it would be for streaming writes.
All sort orders are kept in the manifest in the sort-orders field.
| SortField(source_id=1, transform=IdentityTransform(), direction=SortDirection.ASC, null_order=NullOrder.NULLS_FIRST), | ||
| SortField(source_id=2, transform=IdentityTransform(), direction=SortDirection.DESC, null_order=NullOrder.NULLS_LAST), | ||
| order_id=1, | ||
| ) |
There was a problem hiding this comment.
can you add a test for modifying sort order of a table with existing sort order?
| from pyiceberg.table import Transaction | ||
|
|
||
|
|
||
| class SortOrderBuilder: |
There was a problem hiding this comment.
nit: do we need the builder here? Or just follow UpdateSchema's pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to replace a table's sort order. Closes #1245
Some basic tests are implemented but need to be expanded.
Currently, a new sort order ID is assigned. This adds a sort order to the list of available sort orders rather than replacing it.
@Fokko do you mind taking a look at this and telling me what you think? Thanks in advance!