feat: Support Bucket and Truncate transforms on write #1345
+181
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungwy
force-pushed
the
bucket-transforms
branch
from
560ba20 to
bd80f39
Compare
sungwy
changed the title
sungwy
changed the title
kevinjqliu
approved these changes
Dec 24, 2024
| @pytest.mark.parametrize( | ||
| "spec, expected_rows", | ||
| [ | ||
| # none of non-identity is supported |
There was a problem hiding this comment.
Suggested change
| # none of non-identity is supported |
Comment on lines
+1580
to
+1583
| source_type: PrimitiveType, | ||
| input_arr: Union[pa.Array, pa.ChunkedArray], | ||
| expected: Union[pa.Array, pa.ChunkedArray], | ||
| num_buckets: int, |
There was a problem hiding this comment.
nit: wydt of reordering these for readability? num_buckets, source_type and input_arr are configs of the BucketTransform; expected is the output
There was a problem hiding this comment.
Hmm I think I feel indifferent here - there’s something nice about having the input and expected arrays side by side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting the PR ready for when
pyiceberg_coreis released fromiceberg-rustPR to introduce python binding release: apache/iceberg-rust#705
Fixes: #1074
Consideration: we could replace the existing
pyarrowdependency onorder_preservingtransforms (Month,Year,Date) withpyiceberg_corefor consistency