Do not deprecate botocore_session
#1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
reviewed
Nov 6, 2024
| @@ -98,6 +99,7 @@ def __init__(self, name: str, **properties: str): | |||
| session = boto3.Session( | |||
| profile_name=properties.get(DYNAMODB_PROFILE_NAME), | |||
| region_name=get_first_property_value(properties, DYNAMODB_REGION, AWS_REGION), | |||
| botocore_session=properties.get(DEPRECATED_BOTOCORE_SESSION), | |||
There was a problem hiding this comment.
Do we want to emit a deprecation message? I feel like there is no strong consensus on how to move this forward, and I would also love to get @HonahX's input on it. Same for Glue below
There was a problem hiding this comment.
im ok with leaving it as is now, and deferring to the next release
Fokko
approved these changes
Nov 6, 2024
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* remove botocore_session deprecation message * add back DEPRECATED_BOTOCORE_SESSION * add deprecation message
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* remove botocore_session deprecation message * add back DEPRECATED_BOTOCORE_SESSION * add deprecation message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not deprecate
botocore_sessionin 0.8.0 release, due to #1104Partial revert of #1269
Fixes #1104