Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VisitorWithPartner for name-mapping #1014

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Aug 7, 2024

This will correctly handle fields with . in the name. Resolves #935

WDYT @sungwy ?

This will correctly handle fields with `.` in the name.
Copy link
Collaborator

@sungwy sungwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Fokko - LGTM just left two nitty comments 🧐

pyiceberg/table/name_mapping.py Outdated Show resolved Hide resolved
pyiceberg/table/name_mapping.py Outdated Show resolved Hide resolved
Fokko and others added 2 commits August 8, 2024 10:37

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Sung Yun <[email protected]>
@Fokko Fokko requested a review from sungwy August 12, 2024 09:55
@sungwy sungwy merged commit 5cce906 into apache:main Aug 13, 2024
7 checks passed
sungwy added a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
* Use `VisitorWithPartner` for name-mapping

This will correctly handle fields with `.` in the name.

* Fix versions in deprecation

Co-authored-by: Sung Yun <[email protected]>

* Use full path in error

---------

Co-authored-by: Sung Yun <[email protected]>
sungwy added a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
* Use `VisitorWithPartner` for name-mapping

This will correctly handle fields with `.` in the name.

* Fix versions in deprecation

Co-authored-by: Sung Yun <[email protected]>

* Use full path in error

---------

Co-authored-by: Sung Yun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NameMapping flattens the names and causes a.b field to collide with child b field of field a
2 participants