-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: support aliyun oss backend. #216
base: main
Are you sure you want to change the base?
Conversation
abd9610
to
6a14f50
Compare
Signed-off-by: divinerapier <[email protected]>
6a14f50
to
0576e0f
Compare
@zeroshade Fixed, PTAL |
This seems generally good to me. Does Aliyun have something similar to how MinIO works for S3 that can be added to the integration tests to have CI testing the backend? i.e. is there any way to use a docker image to run something that simulates the Aliyun backend for testing? |
Automated integration testing is indeed crucial. However, unfortunately, I haven't yet found a reasonable and convenient way to access OSS services in the integration testing environment. I've tried the following approaches:
Therefore, regarding OSS integration testing implementation, I haven't been able to identify other viable solutions. Since this modification is being used in our company's actual project, the good news is that we haven't encountered any issues in production so far. |
the Java iceberg impl has some mocking and test setups for Aliyun as seen here would it make sense to create a similar utility in Go? or is it not worth that effort there? Is there any sort of testing we could add here for this? |
Overview
This PR adds support for using Aliyun Object Storage Service (OSS) as a backend storage option.
Changes