Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add compaction server supporting remote compaction service #1547

Closed
wants to merge 28 commits into from
Closed

feat: add compaction server supporting remote compaction service #1547

wants to merge 28 commits into from

Conversation

LeslieKid
Copy link
Contributor

@LeslieKid LeslieKid commented Jul 19, 2024 •
edited
Loading

Rationale

The subtask to support compaction offloading. See #1545

Detailed Changes

  • Define CompactionServiceImpl to support compaction rpc service.
  • Introduce NodeType and enable the deployment of CompactionServer.
  • Impl compaction_client for HoraeDB to access remote compaction node.
  • Update doc for CompactionServer in cluster mode.

Test Plan

CI test

@github-actions github-actions bot added the feature New feature or request label Jul 19, 2024
@LeslieKid LeslieKid mentioned this pull request Jul 19, 2024
Open
3 tasks
@tanruixiang tanruixiang requested a review from jiacai2050 July 22, 2024 09:48
@tanruixiang
Copy link
Member

Interesting, looking forward to finishing.

LeslieKid and others added 16 commits July 23, 2024 15:32
@LeslieKid
define error for compaction service.
3d007e1
@LeslieKid
enable conversation from request to task.
453b22c
@LeslieKid
update remote compact execution.
b549119
@LeslieKid
enable conversation from task result to response.
ec60fdc
@LeslieKid
introduce CompactionCluster for compaction server in distribute mode.
d3b4db2
@LeslieKid
enable compaction cluster deployment.
798dd41
@LeslieKid
refactor: replace CompactionCluster with ClusterType.
cd7c9ae
@LeslieKid
remove compaction cluster,
818d61f
@LeslieKid
fix style and comment.
31a306c
@LeslieKid
provide cluster type for communication between horaedb/cs (as client)…
29894f8 
… and horaemeta.
@LeslieKid
introduce compaction client for horaedb to access remote compaction n…
12f135a 
…ode.
@LeslieKid
impl compact in Cluster trait.
a999f41
@LeslieKid
fix style and add comment.
165c18d
@LeslieKid
impl type conversation.
f306c14
@LeslieKid
remove dead code.
c01ef00
@LeslieKid
Merge branch 'main' into remote-compaction-service
e170f65
@LeslieKid LeslieKid marked this pull request as ready for review August 16, 2024 04:21
@LeslieKid LeslieKid marked this pull request as draft August 16, 2024 07:49
@LeslieKid LeslieKid marked this pull request as ready for review August 16, 2024 08:25
@LeslieKid
Copy link
Contributor Author

This pr is similar to #1563 . Close it.

@LeslieKid LeslieKid closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacai2050 jiacai2050 Awaiting requested review from jiacai2050

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeslieKid @tanruixiang