Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align thread name when helix task executor are recreated. #2999

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

xyuanlu
Copy link
Contributor

@xyuanlu xyuanlu commented Jan 18, 2025

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

#2991

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Align thread name when helix task executor are recreated.

Tests

  • The following tests are written for this issue:

(List the names of added unit/integration tests)

  • The following is the result of the "mvn test" command on the appropriate module:

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@xyuanlu xyuanlu marked this pull request as ready for review January 21, 2025 17:41
Copy link

@klsince klsince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix!

@xyuanlu
Copy link
Contributor Author

xyuanlu commented Jan 21, 2025

This PR is ready to be merged. approved by @klsince
Commit message
Align thread name when helix task executor are recreated.

@xyuanlu xyuanlu merged commit 886bc24 into apache:master Jan 21, 2025
2 checks passed
@klsince
Copy link

klsince commented Jan 21, 2025

Is it possible to cherry pick this and make a hotfix version for 1.3.1? Or any other suggestions to get this fix sooner than later? Thank you!

We are using 1.3.1 currently.

@Jackie-Jiang
Copy link

There is another critical fix #2995 needed by Pinot. Do you think you can make a new release?

zpinto pushed a commit to zpinto/helix that referenced this pull request Jan 22, 2025
Align thread name when helix task executor are recreated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants