HADOOP-19233: ABFS: [FnsOverBlob] Implementing Rename and Delete APIs over Blob Endpoint #7265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhattmanish98
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
bhattmanish98
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
anujmodi2021
requested changes
Jan 7, 2025
| AUTHORIZATION_PERMISSION_MISS_MATCH("AuthorizationPermissionMismatch", HttpURLConnection.HTTP_FORBIDDEN, null), | ||
| ACCOUNT_REQUIRES_HTTPS("AccountRequiresHttps", HttpURLConnection.HTTP_BAD_REQUEST, null), | ||
| MD5_MISMATCH("Md5Mismatch", HttpURLConnection.HTTP_BAD_REQUEST, | ||
| "The MD5 value specified in the request did not match with the MD5 value calculated by the server."), | ||
| COPY_BLOB_FAILED("COPY_BLOB_FAILED", HttpURLConnection.HTTP_INTERNAL_ERROR, null), |
There was a problem hiding this comment.
Error Codes should be in camelcase as others
|
|
||
| package org.apache.hadoop.fs.azurebfs.enums; | ||
|
|
||
| public enum BlobCopyProgress { |
There was a problem hiding this comment.
Javadoc for class and enums
| @@ -49,6 +49,9 @@ public interface SASTokenProvider { | |||
| String SET_PERMISSION_OPERATION = "set-permission"; | |||
| String SET_PROPERTIES_OPERATION = "set-properties"; | |||
| String WRITE_OPERATION = "write"; | |||
| String COPY_BLOB_DESTINATION = "copy-blob-dst"; | |||
There was a problem hiding this comment.
Need to discuss this change once, we do not support UDS for FNS Blob
| destination, sourceEtag, isAtomicRenameKey(source), tracingContext | ||
| ); | ||
| incrementAbfsRenamePath(); | ||
| return blobRenameHandler.execute(); |
There was a problem hiding this comment.
This might need rechecking. We do not want to return op as null.
| final TracingContext tracingContext, | ||
| final boolean isNamespaceEnabled) throws AzureBlobFileSystemException { | ||
| getBlobDeleteHandler(path, recursive, tracingContext).execute(); | ||
| return null; |
There was a problem hiding this comment.
Why are we returning null here?
| @@ -201,4 +238,25 @@ public int getAcquireRetryCount() { | |||
| public TracingContext getTracingContext() { | |||
| return tracingContext; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Java docs for all public methods and classes
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.fs.azurebfs.services; |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
| * Blob copy API is an async API, this configuration defines polling duration | ||
| * for checking copy status {@value} | ||
| */ | ||
| public static final String FS_AZURE_BLOB_COPY_PROGRESS_WAIT_MILLIS = "fs.azure.blob.copy.progress.wait.millis"; |
There was a problem hiding this comment.
keep the comments formatting constant
| @@ -104,5 +104,9 @@ public final class HttpHeaderConfigurations { | |||
| */ | |||
| public static final String X_MS_BLOB_CONTENT_MD5 = "x-ms-blob-content-md5"; | |||
|
|
|||
| public static final String X_MS_COPY_ID = "x-ms-copy-id"; | |||
There was a problem hiding this comment.
javadocs for new constants
| @@ -359,6 +375,34 @@ public AbfsRestOperation listPath(final String relativePath, final boolean recur | |||
| return op; | |||
| } | |||
|
|
|||
| private void fixAtomicEntriesInListResults(final AbfsRestOperation op, | |||
There was a problem hiding this comment.
add javadocs for all methods wherever missing
| @@ -338,6 +353,7 @@ public AbfsRestOperation listPath(final String relativePath, final boolean recur | |||
| requestHeaders); | |||
|
|
|||
| op.execute(tracingContext); | |||
| fixAtomicEntriesInListResults(op, tracingContext); | |||
There was a problem hiding this comment.
explain the need for the same
| List<BlobListResultEntrySchema> filteredEntries = new ArrayList<>(); | ||
| for (BlobListResultEntrySchema entry : listResultSchema.paths()) { | ||
| if (!takeListPathAtomicRenameKeyAction(entry.path(), | ||
| (int) (long) entry.contentLength(), tracingContext)) { |
There was a problem hiding this comment.
double casting is not needed, we can use something like :-
Long longValue = 12345L;
int intValue = longValue.intValue();
| @@ -45,6 +45,8 @@ public enum AzureServiceErrorCode { | |||
| INVALID_SOURCE_OR_DESTINATION_RESOURCE_TYPE("InvalidSourceOrDestinationResourceType", HttpURLConnection.HTTP_CONFLICT, null), | |||
| RENAME_DESTINATION_PARENT_PATH_NOT_FOUND("RenameDestinationParentPathNotFound", HttpURLConnection.HTTP_NOT_FOUND, null), | |||
| INVALID_RENAME_SOURCE_PATH("InvalidRenameSourcePath", HttpURLConnection.HTTP_CONFLICT, null), | |||
| DIRECTORY_NOT_EMPTY_DELETE("DirectoryNotEmpty", HttpURLConnection.HTTP_CONFLICT, | |||
There was a problem hiding this comment.
naming could be changed
| } else { | ||
| throw new AbfsRestOperationException(HTTP_INTERNAL_ERROR, | ||
| AzureServiceErrorCode.UNKNOWN.getErrorCode(), | ||
| "FNS-Blob Rename was not successfull", |
There was a problem hiding this comment.
Should add path or file name as well where rename failed
| throw ex; | ||
| } | ||
| } | ||
| return true; |
There was a problem hiding this comment.
why are we directly returning true here and not checking for renameSrchasChanged as in the previous method ?
|
|
||
| /** | ||
| * Orchestrator for delete over Blob endpoint. Blob endpoint for flat-namespace | ||
| * account does not support director delete. This class is responsible for |
| try { | ||
| /* | ||
| * Delete the required path. | ||
| * Directory needs to be safely delete the path, as the path can be implicit. |
There was a problem hiding this comment.
typo: grammar issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR:
This PR is in correlation to the series of work done under Parent Jira: [HADOOP-19179]
Jira for this Patch: [HADOOP-19233]
Currently, we only support rename and delete operations on the DFS endpoint. The reason for not supporting rename and delete operations on the Blob endpoint is that the Blob endpoint does not account for hierarchy. We need to ensure that the HDFS contracts are maintained when performing rename and delete operations. Renaming or deleting a directory over the Blob endpoint requires the client to handle the orchestration and rename or delete all the blobs within the specified directory.
The task outlines the considerations for implementing rename and delete operations for the FNS-blob endpoint to ensure compatibility with HDFS contracts.